[Bf-committers] OpenMP issues with msvc2013 builds

[Chad Fraleigh]

On Wed, Aug 6, 2014 at 1:45 PM, Martijn Berger <martijn.berger at gmail.com>
wrote:


> Main problem is that someone needs to actually try this by implementing it
> :)


For the pre-patch fix, the byte at offset 0x000169A0 in the 32-bit
vcomp120.dll (assuming the same one in 2.71) should be changed to 0x00 (the
'bool' for active, which defaults to 0x01).

The prior contents in that area are:

00016980:    FD 83 8F AF 06 94 7D 11 E4 2D DE 9F CE D2 C8 04
......}..-......
00016990:    DD A6 D8 0A FF FF FF FF 01 00 00 00 01 00 00 00
................
000169A0:    01 01 00 00 01 00 00 00 00 00 00 00 00 00 00 00
................
000169B0:    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
................


I ran an install of 2.71 with a patch dll and it didn't give any errors
loading it (e.g. checksum/signature mismatch). But since I don't know what
to look for with the CPU issue manifestation, I couldn't test it further.


Since Olly only supports 32-bit code, I couldn't easily identify the
location for the 64-bit dll. I would have to resort to using WinDbg or
something (ugg!). But since this is only a proof of concept, I assume it
shouldn't be needed at this point.


-Chad