[Bf-committers] UI alignement changes in r59434
Jens Verwiebe
info at jensverwiebe.de
Sun Sep 29 14:43:20 CEST 2013
Ok folks
For addons using extensions_framework, i just found a solution thats very simple (globally ).
This fixes then luxrender and afaik yafaray and mitsuba.
Looks as it'S being on hold atm. for i'am not the owner of this files ( Doug Hammond - dougal2 is )
So here just the change i tested ok :
===================================================================
--- ui.py (revision 4777)
+++ ui.py (working copy)
@@ -161,7 +161,7 @@
else:
splt = layout.row(True)
for sp in next_items:
- col2 = splt.column()
+ col2 = splt.column(align=True)
self.draw_column(sp, col2, context, supercontext,
property_group)
else:
Cheers .... Jens
Am 29.09.2013 um 13:54 schrieb Thomas Dinges <blender at dingto.org>:
> Hi everyone,
> A few weeks ago the behaviour for UI alignement changed:
> https://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=59434
> I alreaddy raised concerns back then, but didn't push hard enough, as I
> was unsure myself.
>
> Well, the main problem here is, that it breakes UIs. For Blender itself,
> various fixes were needed after that commit.
> Let's have an example:
>
> Before the change, this code was fine:
> col = layout.column(align=True)
> rol = col.row()
> row.prop()
> row.prop()
>
> As the mother layout (col) was aligned, the sublayouts were too. Now we
> need to specify align=True in the sublayout too, otherwise it's lost.
> rol = col.row(align=True)
>
> I think we should solve this in the other way. Basically, revert to the
> former behaviour, but allow people to disable the alignement in sublayouts.
> col = layout.column(align=True)
> rol = col.row(align=False)
> row.prop()
> row.prop()
>
> This would not break the API, and would be more intutitive as well imo.
>
> I just talked to Jens in IRC, the Luxrender Addon suffers a lot from
> this change, and we both did not find an easy solution to change it
> (easy = not change hundreds of lines manually).
> I am sure more Addons have this problem. Also I don't see this obvious
> Py API Breackage mentioned anywhere?
> http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.69
>
> Can we please revert to the former state, and if possible add the
> align=False override possibility?
>
> Best regards,
> Thomas
>
>
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
_____________________________________
Jens Verwiebe
Allerskehre 44 - 22309 Hamburg
Tel.: +49 40 68 78 50
mobil: +49 172 400 49 07
mailto: info at jensverwiebe.de
web: http://www.jensverwiebe.de
_____________________________________
More information about the Bf-committers
mailing list