[Bf-committers] Blender 2.69 testbuild1 AHOY

[Tamito KAJIYAMA]

Thank you Irie-san for the fix, I was not aware of the issue.

And now I see better the downside of using the brush icon for line
styles -- it is not nice to see two brush icons (one for brushes and the
other for line styles) shown in the ID block selector. I would be
grateful if a new icon is given to Freestyle line style ID blocks
(possibly in the release after 2.69).

-- 
KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>


On 26/09/2013 09:03, IRIE Shinsuke wrote:
> I've changed id_type_items to use the brush icon rather than the
> particle icon in r60379.
>
> IRIE Shinsuke
>
> 13/09/26, IRIE Shinsuke wrote:
>>> I wouldn't be bothered with the present icon (originally intended for
>>> brushes) though.
>>
>> Using the brush icon looks strange to me because the line style is
>> quite different from the brushes...
>>
>> Anyway, the most confusing thing is the particle icon
>> (ICON_PARTICLE_DATA) is used for the ID-block type of line style in
>> rna_ID.c.  In driver variable panels on the Graph Editor, ID-type
>> selector and ID-block selector use the different icons for line style.
>>
>> Did you use the particle icon there by mistake?
>>
>> IRIE Shinsuke
>>
>> 13/09/26, Tamito KAJIYAMA wrote:
>>>    > Tamito-san, did you ask anyone to create the line style icon?
>>>
>>> No, I didn't. I would appreciate it if the person responsible for icon
>>> design is willing to create one for Freestyle line style data blocks.
>>> I wouldn't be bothered with the present icon (originally intended for
>>> brushes) though.
>>>
>>> Regards,