[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [60692] trunk/blender/source/blender: Fix build scripts related to PSD support.

[PerfectionCat]

Because there are many source files which I have not yet watched, I cannot still explain a basic cause.
However, I report the contents which I revised in OpenImageIO library.
Please consider whether it is appropriate in you.
The file which I revised is psdinput.cpp.
When Blender is going to found original psd file enclosed by PhotoShop, it fails in create of OiiO.
It is because Blender fails in generation of class PSDInput.
It causes function init in constructer and destructor.
There is the following execute statement in function init.

m_file.close ();

I deleted this from function init and added it in function close.
I can read original psd file when I use the library which I make modifications like that and made.


I was going to investigate why only windows did not act, but gave it up because I did not have other environment.


PerfectionCat


----- Original Message -----
>From: Dalai Felinto <dfelinto at gmail.com>
>To: bf-blender developers <bf-committers at blender.org>; Brecht Van Lommel <brechtvanlommel at pandora.be> 
>Date: 2013/10/12, Sat 09:47
>Subject: Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [60692] trunk/blender/source/blender: Fix build scripts related to PSD support.
> 
>Hi,
>
>> it causes unwanted behavior that the PSD support is enabled even if
>WITH_IMAGE_OPENIMAGEIO=OFF and WITH_CYCLES=ON
>
>This is actually the wanted behaviour. Bear with me ...
>
>If the average user just builds Blender, she gets Cycles, PSD, all the
>goodies.
>
>If the advanced user/developer doesn't want to build Cycles but wants PSD
>support, she does WITH_CYCLES=OFF and WITH_IMAGE_OPENIMAGEIO=ON
>
>If the user doesn't want anything to use OIIO, she simply does
>WITH_CYCLES=OFF.
>
>I believe (may be wrong) that one of main ideas of having those defines in
>the code is to speed up building (less code to build, less libraries to
>link to ...). Thus I think we should tie the defines to the library, not
>the feature.
>
>Dalai // mobile
>_______________________________________________
>Bf-committers mailing list
>Bf-committers at blender.org
>http://lists.blender.org/mailman/listinfo/bf-committers
>
>
>