[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [60497] trunk/blender/source/blender/ editors/interface/interface_handlers.c: OSX/keys: change to OSX conform cmd-a for 'select-all' in text(-boxes)

[IRIE Shinsuke]

Thanks, I've been aware that the actions in the text field are not
operators but I was not sure why we don't use operators.

IRIE Shinsuke

13/10/03, Campbell Barton wrote:
> On Wed, Oct 2, 2013 at 2:26 PM, IRIE Shinsuke <irieshinsuke at yahoo.co.jp> wrote:
>> Why don't we use a keymap for the text input field?
>
> Because these actions are not operators which could be triggered by a
> keymap (currently the way keymaps work each key stores an operator
> identifier),
> So instead the events are handled directly, the UI could be made to
> use operators but this likely isn't such a trivial change.
>
> Note that the old keybinding is working again in svn.
>
>> I'm a Linux+Emacs user so I want to use Emacs style key bindings
>> anywhere in Blender, but cannot customize the key bindings of the
>> text input field.  Especially, utf8 input using XIM becomes a
>> mixture of the different styles of key bindings...
>>
>> IRIE Shinsuke
>>
>> 13/10/02, Campbell Barton wrote:
>>> Blender so far keeps cross platform key bindings (with a few rare
>>> exceptions we cant avoid like Shift+Numpad on Windows because its not
>>> supported), there is some advantage that a tutorial/screencast on one
>>> platform can be used on another.
>>>
>>> I'd like some input from other devs here (OSX devs spesifiically), but
>>> I can't see a good reason to disable keys that used to work and that
>>> work on every other platform.
>>>
>>> On Wed, Oct 2, 2013 at 4:49 AM, Jens Verwiebe <info at jensverwiebe.de> wrote:
>>>> Hi Cambo
>>>> I'd say supporting both is wrong.
>>>> Ctrl-a is not an OSX-convention for "Select-all" but "Move to beginning of line/paragraph"
>>>> Jens
>>>>
>>>>
>>>> Am 01.10.2013 um 20:26 schrieb Campbell Barton <ideasman42 at gmail.com>:
>>>>
>>>>> Shouldn't both be supported?
>>>>> As far as I can tell, up until now we've added OSX Cmd-key where its
>>>>> expected but leave Ctrl working too.
>>>>>
>>>>> On Wed, Oct 2, 2013 at 3:47 AM, jens verwiebe <info at jensverwiebe.de> wrote:
>>>>>> Revision: 60497
>>>>>>            http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=60497
>>>>>> Author:   jensverwiebe
>>>>>> Date:     2013-10-01 17:47:08 +0000 (Tue, 01 Oct 2013)
>>>>>> Log Message:
>>>>>> -----------
>>>>>> OSX/keys: change to OSX conform cmd-a for 'select-all' in text(-boxes)
>>>>>>
>>>>>> Modified Paths:
>>>>>> --------------
>>>>>>      trunk/blender/source/blender/editors/interface/interface_handlers.c
>>>>>>
>>>>>> Modified: trunk/blender/source/blender/editors/interface/interface_handlers.c
>>>>>> ===================================================================
>>>>>> --- trunk/blender/source/blender/editors/interface/interface_handlers.c 2013-10-01 16:40:11 UTC (rev 60496)
>>>>>> +++ trunk/blender/source/blender/editors/interface/interface_handlers.c 2013-10-01 17:47:08 UTC (rev 60497)
>>>>>> @@ -2228,7 +2228,11 @@
>>>>>>
>>>>>>                          case AKEY:
>>>>>>                                  /* Ctrl + A: Select all */
>>>>>> +#if !defined(__APPLE__)
>>>>>>                                  if (event->ctrl && !(event->alt || event->shift || event->oskey)) {
>>>>>> +#else
>>>>>> +                               if (event->oskey && !(event->alt || event->shift || event->ctrl)) { // OSX conformity
>>>>>> +#endif
>>>>>>                                          ui_textedit_move(but, data, STRCUR_DIR_PREV,
>>>>>>                                                           false, STRCUR_JUMP_ALL);
>>>>>>                                          ui_textedit_move(but, data, STRCUR_DIR_NEXT,
>>>>>>
>>>>>> _______________________________________________
>>>>>> Bf-blender-cvs mailing list
>>>>>> Bf-blender-cvs at blender.org
>>>>>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> - Campbell
>>>>> _______________________________________________
>>>>> Bf-committers mailing list
>>>>> Bf-committers at blender.org
>>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>>
>>>> _____________________________________
>>>>
>>>> Jens Verwiebe
>>>> Allerskehre 44  -  22309 Hamburg
>>>>
>>>> Tel.: +49 40 68 78 50
>>>> mobil: +49 172 400 49 07
>>>> mailto: info at jensverwiebe.de
>>>> web:  http://www.jensverwiebe.de
>>>> _____________________________________
>>>>
>>>> _______________________________________________
>>>> Bf-committers mailing list
>>>> Bf-committers at blender.org
>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>
>>>
>>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>
>
>