[Bf-committers] arc diff no longer waits for my comment editing ...

[Dalai Felinto]

If you didn't change anything the problem may be with subsequent patches
(i.e., the second time you run arc diff from the same branch).

The easy way to test is by creating a new branch and see if you get the old
or the new behaviour.

Another option is doing arc init (may be wrong, away from PC now). But this
will not append to the original patch.

Anyways, Brecht's suggestion is better but it may be interesting to isolate
the problem regardless
On Nov 29, 2013 6:53 PM, "Gaia" <gaia.clary at machinimatrix.org> wrote:

> arc diff used to behave like this (until about 8 pm CEST):
>
> arc diff
> - asks me to add a comment and opens the configured editor
> - waits for me until i have edited the comment, and saved the file
> - sends the diff plus my comment to phabricator.
>
>
> But suddenly it changed its behaviour slightly:
>
> arc diff
> - asks me to add a comment and opens the configured editor
> - does NOT wait for me and just sends the diff to phabricator
>
> So my edits no longer get uploaded.
> arc does not tell me about any error.
> I did not change (intentionally) any configuration,
> maybe i did something unintentionally though.
>
> Any hint what could have gone wrong ?
>
> -gaia-
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>