[Bf-committers] Commiting someone else patches (Re: [4ea79fc] master: Patch T37363: ...)

[Antonio Ospite]

On Mon, 18 Nov 2013 06:01:27 +0100
GSR <gsr.b3d at infernal-iceberg.com> wrote:

> Hi,
> noreply at git.blender.org (2013-11-18 at 0307.44 +0000):
> > Commit: 4ea79fcdda6523faf875128ef3d6e8a8ecff67c9
> > Author: Joshua Leung
> > Date:   Mon Nov 18 16:06:31 2013 +1300
> > http://developer.blender.org/rB4ea79fcdda6523faf875128ef3d6e8a8ecff67c9
> > 
> > Patch T37363: Highlight bone layers with active bones (as for Object Layers)
> > 
> > Patch by Jose Molina Garcia (sentinel), with style fixes by myself.
> 
> One of git features is that it can differentiate commiter from author,
> so it can go in the proper header instead of hidden in the logs in non
> standard format. ;]
> 
> When using submitted patches it should be automatic, but there is
> always git commit --author "A U Thor <author at example.com>" for manual
> override.
>

Maybe the documentation can mention "git format-patch" for exporting
patches, and "git am" for importing them, this way the commit message
too will be the same the patch author wrote.

> Already added this info to
> http://wiki.blender.org/index.php/Dev:Doc/Tools/Git .
>

Also be careful about the rebase operation, it should be safe when
done from from "git pull --rebase" but in general rebasing must not be
done on public branches, only on local development ones, this is often
overlooked by new git users.

Just my 2c.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?