[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [57023] trunk/blender/source/blender/ editors/space_view3d/drawobject.c: Simple usability fix:

[Campbell Barton]

Dont think this change is good,
- now it ignores the active face theme color.
- active face is darker in wireframe. almost looks like a hole in the
mesh with all selected, (where it used to be a highlight)
- active face is hard to see in solid view (very faint)

On Sun, May 26, 2013 at 3:42 AM, Ton Roosendaal <ton at blender.org> wrote:
> Revision: 57023
>           http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=57023
> Author:   ton
> Date:     2013-05-25 17:42:20 +0000 (Sat, 25 May 2013)
> Log Message:
> -----------
> Simple usability fix:
>
> Mesh editmode, active face was always drawing same stipple pattern color,
> whether face is selected or not.
> Now it uses selection color + stipple. Looks much more consistent.
>
> Modified Paths:
> --------------
>     trunk/blender/source/blender/editors/space_view3d/drawobject.c
>
> Modified: trunk/blender/source/blender/editors/space_view3d/drawobject.c
> ===================================================================
> --- trunk/blender/source/blender/editors/space_view3d/drawobject.c      2013-05-25 17:28:27 UTC (rev 57022)
> +++ trunk/blender/source/blender/editors/space_view3d/drawobject.c      2013-05-25 17:42:20 UTC (rev 57023)
> @@ -2369,7 +2369,10 @@
>
>         if (!BM_elem_flag_test(efa, BM_ELEM_HIDDEN)) {
>                 if (efa == data->efa_act) {
> -                       glColor4ubv(data->cols[2]);
> +                       if (BM_elem_flag_test(efa, BM_ELEM_SELECT))
> +                               glColor4ubv(data->cols[1]);
> +                       else
> +                               glColor4ubv(data->cols[2]);
>                         return DM_DRAW_OPTION_STIPPLE;
>                 }
>                 else {
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs



-- 
- Campbell