[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [56986] trunk/blender/source/blender/ editors/sculpt_paint/paint_image_proj.c: Fix #35426, masking works wrong in projection painting.

Brecht Van Lommel brechtvanlommel at pandora.be
Fri May 24 15:06:32 CEST 2013


On Fri, May 24, 2013 at 10:56 AM, Antony Riakiotakis <kalast at gmail.com> wrote:
> Ah, there must be a slight misunderstanding here. maskbrush_tiled takes
> only the mask texture mapping into account and we don't support 3d mapping
> there.

Ah I see. This seems quite arbitrary though, don't see a reason why it
couldn't support 3D mapping, would be trivial to add.

On Fri, May 24, 2013 at 9:18 AM, Antony Riakiotakis <kalast at gmail.com> wrote:
> Well, there are slight differences, as can be seen here. Alpha controls the
> amount of blending in general while masking controls the amount of blending
> due to the brush having been to the same area before. So it is different
> for tiled vs non tiled case. The code looks like it could be simplified
> somehow and I'll have to think on that but maybe not :). I agree on 3D
> mapping, also yesterday I wondered why there is code to turn off masking
> when there is a texture with certain mapping on. I think this should
> probably go too.

I thought it would be a good idea to let the regular "texture" work
the same but realized now this won't actually work. For the alpha part
it would be ok, but for the RGB colors you can't skip full pixels as
the colors are changing constantly with the brush moving. So I guess
that exception should stay.

Perhaps it's a design issue here that makes things confusing.
Currently there is the "texture" and "mask texture", but the more
useful distinction would be "brush texture" and "surface texture". One
is a way to define a brush shape, the other is a way to paint a
particular texture onto the surface. The former should be tied to the
brush, the latter might actually work better when it's a shared
texture between all brushes.

Anyway, maybe useful to think about later.

Brecht.


More information about the Bf-committers mailing list