[Bf-committers] BCon3 deadline approaching - status offreestyle?

[Tamito KAJIYAMA]

Hi Campbell,

I have updated the implementation of CustomData-based edge/face marks
so as to use edge/poly CD_ORIGINDEX layers instead of adding Freestyle
specific changes to modifiers.  Please take a look at the branch revision
55683.

To get the new implementation working, modifiers seem to need revisions,
since some of the modifiers just leave the CD_ORIGINDEX layers unset (i.e.,
all index entries are zeros).  As pilot cases the Mirror and Solidify modifiers
have been updated as required.  Note that the changes in the modifiers
are general and not specific to Freestyle.

Some Freestyle-specific code is in DerivedMesh.c, which seems unnecessary
but I was not able to sort it out.  Hints and advice in this regard would be
of great help.

I think the use of text blocks to store Freestyle scripts is a good idea and
quite acceptable.  This change seems much less problematic than it appears.
Most branch users rely on the new GUI these days.  The scripting mode is
less used than the past where Python scripting was the only means for
user-defined line stylization.

This change will break old .blend files for sure.  But for the above reason
I don't expect much complains, even if no backward compatibility is given.

I fully agree that this kind of changes should not happen many times.
The coming trunk merger is the best opportunity to address the absolute
path issue.

I will try to stay in the #blendercoders channel as much as possible in the
following days.  Any discussion and help for coding would be appreciated.

Thanks,

-- 
KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>


-----Original Message----- 
From: Campbell Barton
Sent: Sunday, March 31, 2013 12:36 AM
To: bf-blender developers
Subject: Re: [Bf-committers] BCon3 deadline approaching - status offreestyle?

Resolving CustomData, should only be a few hrs work max, discussing
the changes may take more time then just making them.
So I'll create a patch this week which resolves the custom-data issues
I raised, Tamito can check its ok.


I'm more worried about script execution, this is an issue Brecht
raised too. Currently scripts creates absolute paths to the blender
installation directory that gets saved into blend files, while not so
hard to resolve - but this sort of thing we shouldn't be changing once
in trunk since its saved into files.
Tamito - your OK to have this changed to use Text blocks instead?
If this is changed wont it break existing files that use scripts which
were made in the branch? if so is that acceptable?

Would be good if you could come onto IRC to discuss the best way to
deal with this, its not so complicated but need to consider a few
factors and I'd hate to think we make bad choice because we weren't
able to communicate and rushed the feature into trunk.

On Sun, Mar 31, 2013 at 5:13 AM, Tamito KAJIYAMA
<rd6t-kjym at asahi-net.or.jp> wrote:
> Hi Ton,
>
> Thanks a lot for the offer.  I do my best to sort out the CustomData flags issue,
> as well as the other review comments.
>
> With best regards,
>
> --
> KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>
>
>
> -----Original Message-----
> From: Ton Roosendaal
> Sent: Saturday, March 30, 2013 5:29 PM
> To: bf-blender developers
> Subject: Re: [Bf-committers] BCon3 deadline approaching - status offreestyle?
>
> Hi Tamito,
>
> We already are so close... I would feel really bad if we can't solve the last bits!
> I've asked Brecht/Campbell/Sergey if they see ways to help or speed it up.
>
> If one of them comes with a positive message, we could extend BCon2 a week and have everything sorted out in the coming days.
>
> There's also SSS for cycles waiting you know :) And loads of bugs in the tracker!
>
> Laters,
>
> -Ton-
>
> ------------------------------------------------------------------------
> Ton Roosendaal  Blender Foundation   ton at blender.org    www.blender.org
> Blender Institute   Entrepotdok 57A  1018AD Amsterdam   The Netherlands
>
> On 29 Mar, 2013, at 21:03, Tamito KAJIYAMA wrote:
>
>> Hi Ton,
>>
>> I agree that the issue of CustomData-based flags is likely more time-consuming
>> than the other issues.  I feel like the CustomData stuff may require a few more
>> interactions with core developers (mostly Campbell) to sort out implementation
>> details and smooth the merger.  I would say this may take one week at least.
>> However I would not ask for an extended deadline, as it could be worthless to
>> have it in the end.
>>
>> Thanks,
>>
>> --
>> KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>
>>
>>
>> -----Original Message-----
>> From: Ton Roosendaal
>> Sent: Friday, March 29, 2013 4:51 PM
>> To: bf-blender developers
>> Subject: Re: [Bf-committers] BCon3 deadline approaching - status offreestyle?
>>
>> Hi Tamito,
>>
>> Yes it seems the first issue might be best for branch, but the rest could be done later as well (or are simple).
>>
>> The main question is if we can handle this within our planning, or whether you propose to extend the deadline a bit?
>>
>> -Ton-
>>
>> ------------------------------------------------------------------------
>> Ton Roosendaal  Blender Foundation   ton at blender.org    www.blender.org
>> Blender Institute   Entrepotdok 57A  1018AD Amsterdam   The Netherlands
>>
>> On 29 Mar, 2013, at 17:34, Tamito KAJIYAMA wrote:
>>
>>> Hi,
>>>
>>> There are a few open issues coming out from branch code reviews.
>>> https://codereview.appspot.com/7416049/
>>> In short:
>>> a. Freestyle-specific CustomData-based flags must not be in the Subdivision Surface modifier
>>> code and have to be moved to  source/blender/render/intern/source/convertblender.c.
>>> b. Having absolute paths to external Freestyle scripts is not a good practice.  Using text blocks
>>> to keep the scripts within .blend files is more appropriate.
>>> c. Copyright information in file headers needs to be updated to properly indicate original
>>> copyright holders (there are copy-and-paste errors in this regard).
>>>
>>> I am currently working on the first issue.  The other issues seem much easier to address.
>>>
>>> Efforts on the Freestyle documentation are also ongoing.
>>> https://docs.google.com/document/d/1k98c5BMFzwtWkH8ZCBfZ3xgkFs10HpNPdr8QF7ulZw8/edit
>>>
>>> There are several sections that need revisions by me.
>>>
>>> Gathering Freestyle demo files may also take more time.
>>>
>>> Thanks,
>>>
>>> --
>>> KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>
>>>
>>>
>>> -----Original Message-----
>>> From: Ton Roosendaal
>>> Sent: Friday, March 29, 2013 9:51 AM
>>> To: bf-blender developers
>>> Subject: [Bf-committers] BCon3 deadline approaching - status of freestyle?
>>>
>>> Hi all,
>>>
>>> In a couple of days we planned to move to "BCon3", meaning that work on stabilizing and bugfixing happens, no (big) new features
>>> get
>>> added anymore.
>>>
>>> Next sunday I'm away for Easter, so I hope we can check before sunday the status with Freestyle?
>>>
>>> Thanks,
>>>
>>> -Ton-
>>>
>>> ------------------------------------------------------------------------
>>> Ton Roosendaal  Blender Foundation   ton at blender.org    www.blender.org
>>> Blender Institute   Entrepotdok 57A  1018AD Amsterdam   The Netherlands