[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [57790] trunk/blender/intern/cycles: Cycles / SSE2:

[Thomas Dinges]

This makes sense, will commit the __KERNEL_SSE2__ change only. Thanks.

Am 27.06.2013 01:58, schrieb Brecht Van Lommel:
> Ah, adding the __KERNEL_SSE2__ to kernel_sse3.cpp is fine with me. I
> would keep the other code though, since util_types.h is also used
> outside the kernel, and on x86_64 we might actually want to use SSE
> code there too.
>
> On Thu, Jun 27, 2013 at 1:49 AM, Thomas Dinges <blender at dingto.org> wrote:
>> Thanks, this fixes it.
>> The problems I had were on vc2008, scons and Win x64.
>>
>> I would suggest the following change, this way it's more clear imho and
>> we would avoid the x64 exception in util_types.h,
>> also the __x86_64__ define is only true for an x64 OS, not a x64 CPU, or
>> do I miss something? :)
>>
>> I mean, it's safe to compile SSE2 and SSE3 kernel with the dedicated
>> flags, which kernel to use is checked on runtime anyways.
>>
>> http://www.pasteall.org/43542/diff
>>
>> Am 27.06.2013 01:30, schrieb Brecht Van Lommel:
>>> I did some other reshuffling now, hopefully fixes the build error. Not
>>> sure which OS/compiler you were seeing the error on though.
>>>
>>> On Thu, Jun 27, 2013 at 1:01 AM, Thomas Dinges <blender at dingto.org> wrote:
>>>> Hi Brecht,
>>>> this unfortunately broke compilation, so I had to do further tweaks.
>>>> http://www.pasteall.org/43541/diff
>>>>
>>>> Now we define the flags we want to use in the actual sse2/sse3 cpu
>>>> kernel files, and include the needed files then in util_types.h
>>>>
>>>> Any suggestion?
>>>>
>>>> Best regards,
>>>> Thomas
>>>>
>>>>
>> --
>> Thomas Dinges
>> Blender Developer, Artist and Musician
>>
>> www.dingto.org
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers


-- 
Thomas Dinges
Blender Developer, Artist and Musician

www.dingto.org