[Bf-committers] Please keep OSL script compatibility

[IRIE Shinsuke]

Hi,

Thanks for the fix, but I still get errors like below:

ERROR: Closure 'specular_toon' is not supported by the current renderer, called from (/tmp/tmpsxc72o.osl:15)

Re-compilation solves this but resets all parameters of the OSL script
nodes, so I have to set them again...  Could you fix this error?
Or, is there any way to keep the node parameters?

BTW, "shader_script_update" button in Properties>Material>Surface panel
seems not working (always grayed out).

IRIE Shinsuke

13/06/10, Brecht Van Lommel wrote:
> I think we should preserve compatibility. It's just a matter of adding
> a function to stdosl.h like this
>
>   closure color specular_toon(normal N, float size, float smooth) {
> return glossy_toon(N, size, smooth); }
>
> On Mon, Jun 10, 2013 at 1:21 PM, Thomas Dinges <blender at dingto.org> wrote:
>> Hi,
>> changing the closure name was a step to keep the code consistent.
>> The toon closures were only experimental before, so I rather not add
>> file compatibility code for this change. (Not sure this is possible
>> even, maybe with some code duplication).
>>
>> Thomas
>>
>> Am 10.06.2013 13:15, schrieb IRIE Shinsuke:
>>> Hi Cycles devs,
>>>
>>> With Blender 2.66/2.67, I've already used OSL closure specular_toon()
>>> in several .blend files (e.g. http://www.blendswap.com/blends/view/67827),
>>> but your recent commit renamed this and broke file compatibility so I
>>> have to modify many many material node settings in the older .blend
>>> files...  That's very annoying.
>>>
>>> To keep the compatibility, could you restore the older name or provide
>>> it as an alias?
>>>
>>> Thanks,
>>>
>>
>>
>> --
>> Thomas Dinges
>> Blender Developer, Artist and Musician
>>
>> www.dingto.org
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>