[Bf-committers] New Editors menu

[Ton Roosendaal]

Hi,

"SPACE_EMPTY" was used in past for showing editors we ditched in the past.
Has no use other than that, and typically we better set it to 3d viewport in these cases.

-Ton-

--------------------------------------------------------
Ton Roosendaal  -  ton at blender.org   -   www.blender.org
Chairman Blender Foundation - Producer Blender Institute
Entrepotdok 57A  -  1018AD Amsterdam  -  The Netherlands



On 9 Jun, 2013, at 17:11, Brecht Van Lommel wrote:

> On Sun, Jun 9, 2013 at 4:34 PM, Bastien Montagne <montagne29 at wanadoo.fr> wrote:
>> The following patch replaces old "manual" Editors menu with nice
>> RNA-based one (so once again, some cleanup of old UI code).
>> 
>> http://www.pasteall.org/42945/diff
> 
> Looks good, one comment below.
> 
>> It makes the following changes:
>> 
>> * Area's type enum still use the same static items, but now has a
>> generator func which produces a nice enum mimicking the old all-text
>> menu, and without the "EMPTY" entry.
>> 
>> The only change I can see a bit risky is the removal of the 'EMPTY'
>> entry in area's type. I made quite a few tests and investigations in
>> code, and could not find any issue, but I'd appreciate more experienced
>> devs' advices here... ;)
> 
> I don't think it should have been there, so seems ok to remove it. Why
> have a rna_Area_type_itemf function then though? I would just reorder
> space_type_items to match the menu and add separators.
> 
>> * Two fixes in code drawing enums as dropdown menu:
>> ** All items were taken into account when computing the number of needed
>> columns, now simple separators (void string items) are ignored. This
>> avoid having two columns in editors menu, but makes sense in general imho!
>> ** Simple separators items were drawn as labels, taking far too much space!
> 
> Ok, makes sense to me.
> 
> Brecht.
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers