[Bf-committers] Blender 2.67b release AHOY!

[Bartek Skorupa (priv)]

Hi Ton,

This is a good lesson for me. I am very sorry for what happened.

With Respect
Bartek Skorupa

www.bartekskorupa.com

On 31 maj 2013, at 10:21, Ton Roosendaal <ton at blender.org> wrote:

> Hi Bartek,
> 
> For our releases we try to keep everyone stick to "only add crucial fixes" in the last weeks before a release, and certainly for an 'a' update.
> 
> I've just checked a few of your commits, but it appears to be regular maintenance and development work as well.
> 
> Add-ons in a release should go via the same ruling as the rest of code. I am not following the add-on tracker commit mails though, might well be happening already :)
> 
> Anyway - perfect releases don't exist. I propose to add a short note on the download page about the Node Efficiency Tools and link to where the update can be loaded.
> 
> We're now 3 weeks after the 2.67 release too, with a bi-monthly cycle a next release would happen within 5-6 six weeks anyway. Let's try to do better next time, and just communicate well about unfortunate errors. 
> 
> -Ton-
> 
> --------------------------------------------------------
> Ton Roosendaal  -  ton at blender.org   -   www.blender.org
> Chairman Blender Foundation - Producer Blender Institute
> Entrepotdok 57A  -  1018AD Amsterdam  -  The Netherlands
> 
> 
> 
> On 30 May, 2013, at 20:36, Bartek Skorupa (priv) wrote:
> 
>> Hi,
>> 
>> It seems that I made a mistake that I would like to apologize for.
>> On May 27th I made a list of my commits that I wanted to be included in 2.67b release.
>> It is all related to node_efficiency_tools.py add on.
>> 
>> In trunk the version is ok, but in my list I omitted one very important commit that removed one syntax error.
>> My list was as follows:
>> 
>> Here's the list of commits:
>> 4514, 4515, 4534, 4537, 4538 and 4541
>> 
>> I ommited commit 4539 that was:
>> 
>> Revision: 4539
>>        http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-extensions&revision=4539
>> Author:   bartekskorupa
>> Date:     2013-05-17 17:45:56 +0000 (Fri, 17 May 2013)
>> Log Message:
>> -----------
>> Bug fix. Simple syntax error. Sorry
>> 
>> Modified Paths:
>> --------------
>>  trunk/py/scripts/addons/node_efficiency_tools.py
>> 
>> Modified: trunk/py/scripts/addons/node_efficiency_tools.py
>> ===================================================================
>> --- trunk/py/scripts/addons/node_efficiency_tools.py	2013-05-17 17:20:20 UTC (rev 4538)
>> +++ trunk/py/scripts/addons/node_efficiency_tools.py	2013-05-17 17:45:56 UTC (rev 4539)
>> @@ -1124,7 +1124,7 @@
>>       valid = False
>>       if (space.type == 'NODE_EDITOR' and
>>               space.node_tree is not None and
>> -                context.active_node is not None and
>> +                context.active_node is not None
>>               ):
>>           valid = True
>>       return valid
>> 
>> Because this commit was omitted now in official release we have syntax error.
>> This is my mistake. I did fix the bug, but when creating list of commits to be included I omitted this very important one.
>> I am very sorry for that.
>> Is there any way of fixing this at this point?
>> 
>> With Respect
>> Bartek Skorupa
>> 
>> www.bartekskorupa.com
>> 
>> On 29 maj 2013, at 19:51, Campbell Barton <ideasman42 at gmail.com> wrote:
>> 
>>> Lets hope this is the last 2.67 release :)
>>> 
>>> Information for platform maintainers:
>>> tag: blender-2.67b-release
>>> tag revision: 57123
>>> addons revision: 4542
>>> locale revision: 1888
>>> 
>>> To avoid doing a full checkout of svn.
>>> 
>>> # first ensure no local changes
>>> svn revert -R .
>>> # check for no additional source files
>>> svn st
>>> # switch to the release tag
>>> svn switch https://svn.blender.org/svnroot/bf-blender/tags/blender-2.67b-release/blender
>>> 
>>> For reference, list of revs merged:
>>> http://wiki.blender.org/index.php/User:Ideasman42/267b_bugfix
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers at blender.org
>>> http://lists.blender.org/mailman/listinfo/bf-committers
>> 
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers