[Bf-committers] "Nodes Efficiency Tools" Add-On permission to move to contrib

[Bassam Kurdali]

Hi Bartek:
I'm not a decision maker at all, but I looked at the code and it
certainly looks good enough- no trouble understanding it, plenty of
comments,  and I could hack a feature in without difficulty if I wanted.
The functionality is great, and I had not encountered any bugs.

+1 from me for inclusion in contrib

PS- the only thing that stands out is it is not pep-8 compliant (at
least lines are too long in some places, and there is a space around the
= when assigning values in function calls and I personally like to see
docs for functions ... but this is all code cleanup suggestions, not me
saying that 'it can't go into trunk' as is.

cheers,
Bassam
On Fri, 2013-01-25 at 13:12 +0100, Bartek Skorupa (priv) wrote:
> Hey,
> 
> I'd like to ask for permission to move my Add-On: "Nodes Efficiency Tools" to contrib.
> 
> tracker: http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
> wiki: http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools
> changelog: http://wiki.blender.org/index.php?title=Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools/Changelog
> video tutorial: http://cg.bartekskorupa.com/nodes-efficiency-tools/
> blenderartists thread: http://blenderartists.org/forum/showthread.php?274755-ADDON-Compositing-Nodes-Efficiency-Tools
> 
> If code review is required - I'd like to ask for this.
> I'm ready to maintain this script.
> As you probably noticed I keep asking about it quite frequently.
> I don't get any answers and I think there may be several reasons:
> 
> 1. No-one has a time.
> This is understandable. I will simply try again and again, maybe some day…
> 
> 2. I'm too impatient, I should sit quiet and wait for my turn.
> Well, I understand, just let me know :-)
> 
> 3. There's no need for such add-on because most of the features it gives are planned to be implemented anyway.
> If so - I'd gladly share any thought I may have, maybe I can be of some help.
> 
> 4. There's no need for such add-on at all.
> Well, I understand, just let me know :-)
> 
> 5. The Add-On is so poorly coded that no-one wants to waste time reviewing such crap.
> If so - just let me know :-)
> 
> With Respect
> Bartek Skorupa
> 
> www.bartekskorupa.com
> 
> On 21 sty 2013, at 08:19, Bartek Skorupa (priv) <bartekskorupa at bartekskorupa.com> wrote:
> 
> > Hello,
> > 
> > If anyone finds some time to review the code of "Nodes Efficiency Tools", I'd really appreciate.
> > As an author I believe that it's useful and ready to be moved to "contrib".
> > 
> > tracker: http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
> > wiki: http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools
> > changelog: http://wiki.blender.org/index.php?title=Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools/Changelog
> > video tutorial: http://cg.bartekskorupa.com/nodes-efficiency-tools/
> > blenderartists thread: http://blenderartists.org/forum/showthread.php?274755-ADDON-Compositing-Nodes-Efficiency-Tools
> > 
> > I keep updating the code, the latest release is always available as an attachment in tracker.
> > Current version: 2.0.04
> > 
> > Regards
> > Bartek Skorupa
> > 
> > www.bartekskorupa.com
> > 
> > On 12 sty 2013, at 22:43, Bartek Skorupa (priv) <bartekskorupa at bartekskorupa.com> wrote:
> > 
> >> Hello,
> >> 
> >> I'd like to ask for reviewing the code of Add On: "Nodes Efficiency Tools"
> >> http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
> >> 
> >> I think it's ready to be included in contrib repository.
> >> The Addon is relatively "young". I published it in the middle of December last year, but it got very good response.
> >> wiki page for it is ready: http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools
> >> Here's a link to video tutorial: http://cg.bartekskorupa.com/nodes-efficiency-tools/
> >> and here's a thread on BA forum: http://blenderartists.org/forum/showthread.php?274755-ADDON-Compositing-Nodes-Efficiency-Tools
> >> 
> >> With Respect
> >> Bartek Skorupa
> >> 
> >> www.bartekskorupa.com
> >> 
> >> _______________________________________________
> >> Bf-committers mailing list
> >> Bf-committers at blender.org
> >> http://lists.blender.org/mailman/listinfo/bf-committers
> > 
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers