[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [53908] trunk/blender/source/blender: patch [#33923] Patch for Node Theme Colors

[Campbell Barton]

On Sun, Jan 20, 2013 at 4:19 AM, Sergey Sharybin <sergey.vfx at gmail.com> wrote:
> I'm not so much sure such approach is indeed cool here.
>
> First, why only matte and distort and not other nodes?
> Second, we already do have custom node colors, which already was served for
> such kind of node highlight. Now we do have two separated ways of affecting
> on visual feedback which is a bit cluttered i think.
>
> IMO, nicer approach would be to define some kind of custom color presets
> for different node types. Any node types, not just two of them. Maybe even
> make it stored in .blend file, because in different projects/files i could
> be interested more in different types of operations. Also, maybe make node
> header depend on custom node color, like shade it by multiplying by 0.5
> (just quick idea).
>
> Color feedback could indeed help here, but currently it's a bit of mess
> here i think and could be made much nicer..
>
>
> On Sat, Jan 19, 2013 at 10:21 AM, Campbell Barton <ideasman42 at gmail.com>wrote:
>
>> Revision: 53908
>>
>> http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=53908
>> Author:   campbellbarton
>> Date:     2013-01-19 04:20:53 +0000 (Sat, 19 Jan 2013)
>> Log Message:
>> -----------
>> patch [#33923] Patch for Node Theme Colors
>> from Gavin Howard (gdh)
>>
>> Modified Paths:
>> --------------
>>     trunk/blender/source/blender/editors/include/UI_resources.h
>>     trunk/blender/source/blender/editors/interface/resources.c
>>     trunk/blender/source/blender/editors/space_node/node_draw.c
>>     trunk/blender/source/blender/makesrna/intern/rna_userdef.c
>>
>> Modified: trunk/blender/source/blender/editors/include/UI_resources.h

Previously all composite node classes had their own color theme except
for these 2.

When reading the patch I also got the initial reaction that it was
some kind of back hack, but found this is following how the node
systems color themes work.

To me its fine to add the colors for those 2 composite nodes, but as
you say it would be nice to have color themes for all node classes in
some more generalized (texture nodes, cycles) - but thats a bigger
task.

-- 
- Campbell