[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [52989] trunk/blender: Adding a new SPH solver that is more physically accurate.

[Campbell Barton]

In particle systems this line looks incorrect:
if (part->fluid->flag & SPH_SOLVER_DDR) {

since it will never be true (SPH_SOLVER_DDR == 0)

Looks like it should be:
if (part->fluid->solver == SPH_SOLVER_DDR) {

On Fri, Dec 14, 2012 at 3:57 PM, Alex Fraser <alex at phatcore.com> wrote:
> Revision: 52989
>           http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=52989
> Author:   z0r
> Date:     2012-12-14 04:57:26 +0000 (Fri, 14 Dec 2012)
> Log Message:
> -----------
> Adding a new SPH solver that is more physically accurate. See patch #29681
>
>     http://projects.blender.org/tracker/index.php?func=detail&aid=29681&group_id=9&atid=127
>
> The solver was mostly implemented by John Mansour at VPAC, with help from me and with funding from the AutoCRC. The SPH formulation is due to Gingold and Monaghan, and the smoothing kernel is due to Wendland.
>
> This solver does not replace the old one; it is available as an option. Note that the new solver uses different units than the old one. The patch page has a couple of attachments that can be used to test the new solver, particularly sphclassical_dam_s0.01_grav.blend (ignore the earlier tests). The simulation in that file compares well with a physical experimental dam break; details in a paper by Changhong Hu and Makoto Sueyoshi, also referred to on that page.
>
> Modified Paths:
> --------------
>     trunk/blender/release/scripts/startup/bl_ui/properties_particle.py
>     trunk/blender/source/blender/blenkernel/BKE_particle.h
>     trunk/blender/source/blender/blenkernel/intern/particle_system.c
>     trunk/blender/source/blender/makesdna/DNA_particle_types.h