[Bf-committers] Rigify addon causes error, error, error,....

[Nathan Vegdahl]

Thanks for the fix Irie!

> Anyway, I don't understand why you did such big changes in Bcon4...

Fair enough.  It seemed like the best option of bad options.  I'm
currently working with a studio to improve Rigify for their pipeline,
but I have a limited amount of time to be on-site working with them.
Given that Rigify is an addon, and not part of Blender proper, I felt
it was worth it for the sake of properly documenting the changes and
milestones instead of having a mega-commit at the end.

There's also a complicating factor, which is that they're working with
SVN blender, so every time they update, it wipes out any local Rigify
changes.

All-in-all, perhaps not the best choice on my part, but it wasn't on a whim.

In any case, I'll avoid this in the future.  Perhaps I ought to
maintain a parallel git repo somewhere for publishing out-of-sync
changes.

--Nathan


On Sat, Feb 16, 2013 at 7:51 PM, IRIE Shinsuke <irieshinsuke at yahoo.co.jp> wrote:
> Hi Nathan,
>
> Your recent commit (r4286) introduced a bug in poll() of the new
> "Rigify Dev Tools".  It causes an error every time UI is updated:
>
> Traceback (most recent call last):
>   File "/home/irie/build/blender2.6/cmake/bin/2.65/scripts/addons/rigify/ui.py", line 206, in poll
>     return obj.mode == 'EDIT_ARMATURE'
> NameError: global name 'obj' is not defined
>
>
> The following patch fixes it:
>
> Index: release/scripts/addons/rigify/ui.py
> ===================================================================
> --- release/scripts/addons/rigify/ui.py (revision 4288)
> +++ release/scripts/addons/rigify/ui.py (working copy)
> @@ -203,7 +203,7 @@
>
>      @classmethod
>      def poll(cls, context):
> -        return obj.mode == 'EDIT_ARMATURE'
> +        return context.mode == 'EDIT_ARMATURE'
>
>      def draw(self, context):
>          r = self.layout.row()
>
>
> Anyway, I don't understand why you did such big changes in Bcon4...
>
> Thanks,
>
> --
> IRIE Shinsuke
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers