[Bf-committers] "Nodes Efficiency Tools" Add-On permission to move to contrib

Sat Feb 2 15:24:39 CET 2013

Since its contrib, You can go ahead and commit.
This means it will show up in the 'Testing' section of addons and
won't be distributed with releases, we can still review this for
inclusions in release after.

On Sun, Feb 3, 2013 at 1:16 AM, Bartek Skorupa (priv)
<bartekskorupa at bartekskorupa.com> wrote:
> Thank you Campbell for reviewing updated code.
> In your comment in tracker you said:
> "Hi Bartek, checked the updated script and LGTM. +1 to commit into contrib."
>
> It means that I have one "+1"
>
> How many "plus ones" do I need to treat this as: "Go ahead, commit"? :-)
> Is your "+1" enough, or I need to wait for others?
>
> Thank you again.
>
> Bartek Skorupa
>
> www.bartekskorupa.com
>
> On 2 lut 2013, at 14:29, Bartek Skorupa (priv) <bartekskorupa at bartekskorupa.com> wrote:
>
>> Thank you Campbell for reviewing the code.
>> I have corrected all issues you pointed out in your review and uploaded latest version to tracker.
>> Yesterday I had doubts about handling keycap items, but during my tests I probably had made some mistakes. I tested everything once again and now in version 2.0.06 it's all exactly as it should be.
>> There is only one thing that I have left untouched although you suggested to change it.
>>
>> line 816 (originally 803):
>> bpy.ops.transform.resize(value = (0.0, 0.0, 0.0))
>>
>> I left it because my goal here is not to simply move all nodes to the same location, but I use this "hack" to later calculate properly the dimensions of my nodes. I know that now nodes have properties "height", "width" and "width_hidden", but unfortunately they don't give me values that I need. That's why I use a hack to add "reroute" node, then select all of my nodes, "resize" them down to zero and then calculate nodes' dimensions basing on their new locations differences. I need to do all this because nodes' locations are calculated in relation to upper left corner of the node and I need to place them in relation to "visual" center of them.
>>
>> I don't know how I can include modified code here: https://codereview.appspot.com/7235078/
>> That's why I'd like to ask you to take a look at my code again. Its new version (2.0.06) is uploaded to the tracker:
>> http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
>>
>> If the code is fine, will I get the permission to upload it to contrib and maybe eventually to trunk?
>>
>> Thank you again
>>
>> Cheers
>>
>> Bartek Skorupa
>>
>> www.bartekskorupa.com
>>
>> On 25 sty 2013, at 23:12, Bassam Kurdali <bassam at urchn.org> wrote:
>>
>>> Hi Bartek:
>>> I'm not a decision maker at all, but I looked at the code and it
>>> certainly looks good enough- no trouble understanding it, plenty of
>>> comments,  and I could hack a feature in without difficulty if I wanted.
>>> The functionality is great, and I had not encountered any bugs.
>>>
>>> +1 from me for inclusion in contrib
>>>
>>> PS- the only thing that stands out is it is not pep-8 compliant (at
>>> least lines are too long in some places, and there is a space around the
>>> = when assigning values in function calls and I personally like to see
>>> docs for functions ... but this is all code cleanup suggestions, not me
>>> saying that 'it can't go into trunk' as is.
>>>
>>> cheers,
>>> Bassam
>>> On Fri, 2013-01-25 at 13:12 +0100, Bartek Skorupa (priv) wrote:
>>>> Hey,
>>>>
>>>> I'd like to ask for permission to move my Add-On: "Nodes Efficiency Tools" to contrib.
>>>>
>>>> tracker: http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
>>>> wiki: http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools
>>>> changelog: http://wiki.blender.org/index.php?title=Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools/Changelog
>>>> video tutorial: http://cg.bartekskorupa.com/nodes-efficiency-tools/
>>>> blenderartists thread: http://blenderartists.org/forum/showthread.php?274755-ADDON-Compositing-Nodes-Efficiency-Tools
>>>>
>>>> If code review is required - I'd like to ask for this.
>>>> I'm ready to maintain this script.
>>>> As you probably noticed I keep asking about it quite frequently.
>>>> I don't get any answers and I think there may be several reasons:
>>>>
>>>> 1. No-one has a time.
>>>> This is understandable. I will simply try again and again, maybe some day…
>>>>
>>>> 2. I'm too impatient, I should sit quiet and wait for my turn.
>>>> Well, I understand, just let me know :-)
>>>>
>>>> 3. There's no need for such add-on because most of the features it gives are planned to be implemented anyway.
>>>> If so - I'd gladly share any thought I may have, maybe I can be of some help.
>>>>
>>>> 4. There's no need for such add-on at all.
>>>> Well, I understand, just let me know :-)
>>>>
>>>> 5. The Add-On is so poorly coded that no-one wants to waste time reviewing such crap.
>>>> If so - just let me know :-)
>>>>
>>>> With Respect
>>>> Bartek Skorupa
>>>>
>>>> www.bartekskorupa.com
>>>>
>>>> On 21 sty 2013, at 08:19, Bartek Skorupa (priv) <bartekskorupa at bartekskorupa.com> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> If anyone finds some time to review the code of "Nodes Efficiency Tools", I'd really appreciate.
>>>>> As an author I believe that it's useful and ready to be moved to "contrib".
>>>>>
>>>>> tracker: http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
>>>>> wiki: http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools
>>>>> changelog: http://wiki.blender.org/index.php?title=Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools/Changelog
>>>>> video tutorial: http://cg.bartekskorupa.com/nodes-efficiency-tools/
>>>>> blenderartists thread: http://blenderartists.org/forum/showthread.php?274755-ADDON-Compositing-Nodes-Efficiency-Tools
>>>>>
>>>>> I keep updating the code, the latest release is always available as an attachment in tracker.
>>>>> Current version: 2.0.04
>>>>>
>>>>> Regards
>>>>> Bartek Skorupa
>>>>>
>>>>> www.bartekskorupa.com
>>>>>
>>>>> On 12 sty 2013, at 22:43, Bartek Skorupa (priv) <bartekskorupa at bartekskorupa.com> wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> I'd like to ask for reviewing the code of Add On: "Nodes Efficiency Tools"
>>>>>> http://projects.blender.org/tracker/index.php?func=detail&aid=33543&group_id=153&atid=467
>>>>>>
>>>>>> I think it's ready to be included in contrib repository.
>>>>>> The Addon is relatively "young". I published it in the middle of December last year, but it got very good response.
>>>>>> wiki page for it is ready: http://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/Nodes/Nodes_Efficiency_Tools
>>>>>> Here's a link to video tutorial: http://cg.bartekskorupa.com/nodes-efficiency-tools/
>>>>>> and here's a thread on BA forum: http://blenderartists.org/forum/showthread.php?274755-ADDON-Compositing-Nodes-Efficiency-Tools
>>>>>>
>>>>>> With Respect
>>>>>> Bartek Skorupa
>>>>>>
>>>>>> www.bartekskorupa.com
>>>>>>
>>>>>> _______________________________________________
>>>>>> Bf-committers mailing list
>>>>>> Bf-committers at blender.org
>>>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>>>
>>>>> _______________________________________________
>>>>> Bf-committers mailing list
>>>>> Bf-committers at blender.org
>>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>>
>>>> _______________________________________________
>>>> Bf-committers mailing list
>>>> Bf-committers at blender.org
>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>
>>>
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers at blender.org
>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers

-- 
- Campbell