[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [50813] trunk/blender/source/blender/ makesrna/intern: code cleanup: make many functions static

[Campbell Barton]

now the functions which cycles access are giving warnings again
(-Wmissing-prototypes). Im looking over these I found cycles had an
incorrect definition.

- cycles
void rna_Object_free_duplilist(void *ob, void *reports);
...vs the actual function declaration...
void rna_Object_free_duplilist(struct Object *ob)

I've found these kinds of errors don't always crash - it depends on
the architecture but at least using -Wmissing-prototypes helps expose
problems like this.

On Sun, Sep 23, 2012 at 2:28 PM, Campbell Barton <ideasman42 at gmail.com> wrote:
> If you had to build blender as often as I do (apply patches, go back
> revisions and check for changes, change CFLAGs) - you would see its a
> very good idea!
>
> but point taken - when making changes that effect linking, its good to
> test with cycles on.
>
> On Sun, Sep 23, 2012 at 12:54 AM, Thomas Dinges <blender at dingto.org> wrote:
>> This breaks Cycles compile:
>> http://www.pasteall.org/35464
>>
>> Compiling with everything disabled in cmake is not a good idea ;-)
>>
>> And again, we are in BCon4!
>>
>>
>> Am 22.09.2012 16:07, schrieb Campbell Barton:
>>> Revision: 50813
>>>            http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=50813
>>> Author:   campbellbarton
>>> Date:     2012-09-22 14:07:55 +0000 (Sat, 22 Sep 2012)
>>> Log Message:
>>> -----------
>>> code cleanup: make many functions static
>>>
>> --
>> Thomas Dinges
>> Blender Developer, Artist and Musician
>>
>> www.dingto.org
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>
>
>
> --
> - Campbell



-- 
- Campbell