[Bf-committers] Code base freeze reminder

Sergey Sharybin sergey.vfx at gmail.com
Wed Oct 3 09:28:22 CEST 2012


Hi,

Fix for wrong memory usage seems correct for me and should be applied IMO.

Fix for glare node is also seems correct. The only thing i'm not sure about
if max() is defined in MSVC or some extra header should be applied. Easy to
check using buildbot i think. Wouldn't mind having compilation fix commit
after this.

So after all, LGTM.

On Wed, Oct 3, 2012 at 1:01 PM, Campbell Barton <ideasman42 at gmail.com>wrote:

> Found 4 new bugs from running tests overnight, but think only one is
> important to fix for release.
>
> Own fix for accessing freed memory wasnt working in all cases.
>
> Tracker report, fix attached.
>
> http://projects.blender.org/tracker/index.php?func=detail&aid=32743&group_id=9&atid=498
>
> There was a regression in the glare node, I checked the code against
> the old compositor and there clamping above zero was missing in 2
> places.
>
> Tracker report, fix attached.
>
> http://projects.blender.org/tracker/index.php?func=detail&aid=32739&group_id=9&atid=498
>
> I think these fixes should be applied before release.
>
> On Wed, Oct 3, 2012 at 2:41 AM, Sergey Sharybin <sergey.vfx at gmail.com>
> wrote:
> > Hey!
> >
> > We're officially in release stage now!
> >
> > Please make last checks for possible wrong links, wrong versions used in
> > readme files and so.
> >
> > Splash screen would be commited tomorrow morning as Ton already
> mentioned.
> > Tagging and AHOY will happen afterwards.
> >
> > On Tue, Oct 2, 2012 at 10:31 PM, Ton Roosendaal <ton at blender.org> wrote:
> >
> >> Hi all,
> >>
> >> The version number will go up to 2.64.0 now, so everyone can test if the
> >> version patching works.
> >> If then all's still ok, the splash gets committed and we call AHOY.
> >>
> >> It's better to do this when Sergey and Campbell are both awake, so this
> >> happens in Euro time early morning!
> >>
> >> Thanks,
> >>
> >> -Ton-
> >>
> >> ------------------------------------------------------------------------
> >> Ton Roosendaal  Blender Foundation   ton at blender.org    www.blender.org
> >> Blender Institute   Entrepotdok 57A  1018AD Amsterdam   The Netherlands
> >>
> >> On 2 Oct, 2012, at 16:20, Sergey Sharybin wrote:
> >>
> >> > Hello everyone,
> >> >
> >> > We're entering BCon5 now, meaning no commits to svn trunk should
> happen
> >> for
> >> > until code unfreeze mail.
> >> >
> >> > Committing to other branches is still open of course.
> >> >
> >> > Platform maintainers please stay ready for tomorrow's release AHOY.
> >> >
> >> > --
> >> > With best regards, Sergey Sharybin
> >> > _______________________________________________
> >> > Bf-committers mailing list
> >> > Bf-committers at blender.org
> >> > http://lists.blender.org/mailman/listinfo/bf-committers
> >>
> >> _______________________________________________
> >> Bf-committers mailing list
> >> Bf-committers at blender.org
> >> http://lists.blender.org/mailman/listinfo/bf-committers
> >>
> >
> >
> >
> > --
> > With best regards, Sergey Sharybin
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
>
>
>
> --
> - Campbell
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>



-- 
With best regards, Sergey Sharybin


More information about the Bf-committers mailing list