[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51814] trunk/blender/source/blender/ editors/gpencil/gpencil_paint.c: Bugfix #24030

Joshua Leung aligorith at gmail.com
Tue Nov 6 06:33:56 CET 2012


Hi Ton,

Actually, this breaks the ability to rotate/pan the view with
"sketching sessions" or "poly" draw tool enabled. The impact in the
former case is perhaps not quite as bad, but in the latter case, it
seems to be one of the major drawcards of that tool (at least from a
bug report I saw/fixed last for release).

Joshua

On Fri, Nov 2, 2012 at 6:52 AM, Ton Roosendaal <ton at blender.org> wrote:
> Revision: 51814
>           http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51814
> Author:   ton
> Date:     2012-11-01 17:52:21 +0000 (Thu, 01 Nov 2012)
> Log Message:
> -----------
> Bugfix #24030
>
> Greasepencil mode 'hold d' was also inserting drivers (hotkey D) on mouse over.
> The modal operator was default passing on all events, I made it swallowing it.
> Doesn't seem to be affecting use at all.
>
> Modified Paths:
> --------------
>     trunk/blender/source/blender/editors/gpencil/gpencil_paint.c
>
> Modified: trunk/blender/source/blender/editors/gpencil/gpencil_paint.c
> ===================================================================
> --- trunk/blender/source/blender/editors/gpencil/gpencil_paint.c        2012-11-01 17:16:24 UTC (rev 51813)
> +++ trunk/blender/source/blender/editors/gpencil/gpencil_paint.c        2012-11-01 17:52:21 UTC (rev 51814)
> @@ -1723,7 +1723,7 @@
>  static int gpencil_draw_modal(bContext *C, wmOperator *op, wmEvent *event)
>  {
>         tGPsdata *p = op->customdata;
> -       int estate = OPERATOR_PASS_THROUGH; /* default exit state - not handled, so let others have a share of the pie */
> +       int estate = OPERATOR_RUNNING_MODAL; /* default exit state - we don't pass on events, GP is used with key-modifiers */
>
>         /* if (event->type == NDOF_MOTION)
>          *    return OPERATOR_PASS_THROUGH;
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs


More information about the Bf-committers mailing list