[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46886] trunk/blender: Add skin modifier icon created by Julio Iglesias.

[Brecht Van Lommel]

Hi,

I quite like the separate commits, it really helps to understand what
each change does and makes it easier to detect what exactly was the
cause when something breaks. It think it's actually quite easy to glue
together commits (git rebase -i), but if they make sense on their own
I prefer the commits to be separate, even if it's just an icon file
update. That might not be likely to break anything but you don't know
that beforehand :)

Brecht.

On Tue, May 22, 2012 at 8:12 PM, Nicholas Bishop
<nicholasbishop at gmail.com> wrote:
> I definitely prefer to keep my commits well separated. We won't run
> out of revision numbers any time soon :)
>
> -Nicholas
>
> On Tue, May 22, 2012 at 2:09 PM, Sergey Sharybin <sergey.vfx at gmail.com> wrote:
>> Well, it's really tricky to glue together several git commits before
>> passing them to git-svn. Easy to mess up really important stuff.
>> Personally i can't see what's bad in this case.
>>
>> On Wed, May 23, 2012 at 12:06 AM, Thomas Dinges <blender at dingto.org> wrote:
>>
>>> For the record,
>>> commiting a feature in several commits is okay if it makes sense...but
>>> in this case, 1 extra commit for the icon, one for theme
>>> colors...seriously?
>>>
>>> Thanks!
>>>
>>> Am 22.05.2012 17:19, schrieb Nicholas Bishop:
>>> > Revision: 46886
>>> >
>>> http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=46886
>>> > Author:   nicholasbishop
>>> > Date:     2012-05-22 15:19:13 +0000 (Tue, 22 May 2012)
>>> > Log Message:
>>> > -----------
>>> > Add skin modifier icon created by Julio Iglesias.
>>> >
>>> > Skin modifier documentation:
>>> > http://wiki.blender.org/index.php/User:Nicholasbishop/SkinModifier
>>> >
>>> > Modified Paths:
>>> > --------------
>>> >      trunk/blender/release/datafiles/blender_icons.png
>>> >      trunk/blender/source/blender/editors/datafiles/blender_icons.png.c
>>> >      trunk/blender/source/blender/editors/include/UI_icons.h
>>> >
>>>
>>>
>>> --
>>> Thomas Dinges
>>> Blender Developer, Artist and Musician
>>>
>>> www.dingto.org
>>>
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers at blender.org
>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>
>>
>>
>>
>> --
>> With best regards, Sergey Sharybin
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers