[Bf-committers] Modal bevel operator (issue 6208066)

[ideasman42 at gmail.com]

looks good, still some remaining knitpicks and one question.


http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c
File source/blender/editors/mesh/editmesh_tools.c (right):

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4309
source/blender/editors/mesh/editmesh_tools.c:4309: float *w;
*knitpick* weights ? - better readable

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4495
source/blender/editors/mesh/editmesh_tools.c:4495: static int
edbm_bevel_invoke(bContext *C, wmOperator *op, wmEvent *event)
suggest add "TODO make modal keymap (see fly mode)"

not needed for initial commit

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4509
source/blender/editors/mesh/editmesh_tools.c:4509:
opdata->initial_length = sqrt(mlen[0]*mlen[0] + mlen[1]*mlen[1]);
use len_v2

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4541
source/blender/editors/mesh/editmesh_tools.c:4541: factor =
sqrt(xdiff*xdiff + ydiff*ydiff)/opdata->initial_length;
len_v2

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4653
source/blender/editors/mesh/editmesh_tools.c:4653: static char str[] =
"Confirm: Enter/LClick, Cancel: (Esc/RClick), thickness: %f, depth (Ctrl
to tweak): %f (%s), Outset (O): (%s)";
on topic of keymaps - this kind of string should be generated from modal
keymaps. longer term todo.

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4681
source/blender/editors/mesh/editmesh_tools.c:4681: opdata->modify_depth
= 0;
FALSE

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4800
source/blender/editors/mesh/editmesh_tools.c:4800:
opdata->initial_length = sqrt(mlen[0]*mlen[0] + mlen[1]*mlen[1]);
len_v2

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4830
source/blender/editors/mesh/editmesh_tools.c:4830: depth =
opdata->old_depth + (sqrt(xdiff*xdiff + ydiff*ydiff)
len_v2

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4839
source/blender/editors/mesh/editmesh_tools.c:4839: -
opdata->initial_length)/opdata->initial_length;
len_v2

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4877
source/blender/editors/mesh/editmesh_tools.c:4877:
opdata->initial_length = sqrt(mlen[0]*mlen[0] + mlen[1]*mlen[1]);
len_v2

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4923
source/blender/editors/mesh/editmesh_tools.c:4923:
RNA_def_boolean(ot->srna, "use_relative_offset", TRUE, "Offset
Relative", "Scale the offset by surrounding geometry");
why is this changed?

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/transform/transform.c
File source/blender/editors/transform/transform.c (right):

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/transform/transform.c#newcode1137
source/blender/editors/transform/transform.c:1137: int
calculateTransformCenter(bContext *C, int centerMode, float *cent3d, int
*cent2d)
*knitpick* use cent3d[3], cent2d[2], makes more obvious and means
compilers can detect buffer overruns in places.

http://codereview.appspot.com/6208066/