[Bf-committers] Delkey for button reset problem (issue 5693045)
blend.factory at gmail.com
blend.factory at gmail.com
Thu Feb 23 08:11:47 CET 2012
Reviewers: bf-codereview_blender.org, bf-committers_blender.org,
Description:
Sorry for creating a new issue but for some reason old one
(http://codereview.appspot.com/4535083/) fails and throws an error when
I try to upload new patch set.
Basically, I've seen some complaints on bf-commiters mailing list that
use of Del key under Node editor instead of field reset actually deletes
active node. So, this patch changes Delkey to Backspace key. Again, I
suggest that sole Backspace key should reset only active field and
Ctrl+Backspace should reset a whole active array.
Please review this at http://codereview.appspot.com/5693045/
Affected files:
source/blender/editors/interface/interface_handlers.c
Index: source/blender/editors/interface/interface_handlers.c
===================================================================
--- source/blender/editors/interface/interface_handlers.c (revision 44356)
+++ source/blender/editors/interface/interface_handlers.c (working copy)
@@ -4767,10 +4767,10 @@
}
/* reset to default */
/* XXX hardcoded keymap check.... */
- else if(ELEM(event->type, DELKEY, PADPERIOD) && event->val == KM_PRESS) {
- /* ctrl+del - reset active button; del - reset a whole array*/
+ else if(event->type == BACKSPACEKEY && event->val == KM_PRESS) {
+ /* backspace = reset active button; ctrl+backspace = reset a whole
array*/
if (!(ELEM3(but->type, HSVCIRCLE, HSVCUBE, HISTOGRAM)))
- ui_set_but_default(C, !event->ctrl);
+ ui_set_but_default(C, event->ctrl);
}
/* handle menu */
else if(event->type == RIGHTMOUSE && event->val == KM_PRESS) {
More information about the Bf-committers
mailing list