[Bf-committers] Syntax Highlighting for OSL - Question

[patrick boelens]

Honestly I didn't even know about the Script Node Update button (again 
because I never use extensions internally), but I see what you mean. 
Still though, I imagine there are many different types of users each 
with different preferences and workflows, including those who like me 
tend to forfeit the extension in the file-name, as well as those who 
prefer to not use syntax highlighting. I definitely agree auto-detection
 would be nice to have for those who do use it, but I also feel like 
having the option available won't hurt anyone. Here's the header as-is 
with Syntax Highlighting on and off: 
http://www.pasteall.org/pic/show.php?id=42062. Personally I don't find 
it intrusive at all, so my vote would be to keep it.

Also, thanks for the +1 Thomas!

-Patrick


> From: zanqdo at gmail.com
> Date: Tue, 18 Dec 2012 18:13:27 -0600
> To: bf-committers at blender.org
> Subject: Re: [Bf-committers] Syntax Highlighting for OSL - Question
> 
> Inside a menu is better, yes. For disabling automatic syntax highlighting
> (again I don't know why but what ever). The rest should just work
> 
> Daniel Salazar
> patazstudio.com
> 
> 
> 
> On Tue, Dec 18, 2012 at 6:11 PM, Thomas Dinges <blender at dingto.org> wrote:
> 
> > I disagree with that.
> > A new button inside of a menu in the text editor won't harm.
> >
> > Thanks for the patch Patrick, a welcome addition. I have not looked at the
> > code yet, but OSL syntax highlighting in trunk should be added. +1
> >
> > Best regards, Thomas
> >
> > "Daniel Salazar - 3Developer.com" <zanqdo at gmail.com> schrieb:
> >
> > >Don't think so, the practice of using the extension is already in place
> > >
> > >see py
> > >http://www.pasteall.org/pic/42060
> > >
> > >vs osl
> > >http://www.pasteall.org/pic/show.php?id=42059
> > >
> > >This is a place where you don't have to be smart. It's a
> > >simple syntax highlighting, why would it even be an option? Who would want
> > >to disable syntax highlighting and why? Blender's UI is already filled
> > with
> > >options.
> > >
> > >cheers
> > >
> > >Daniel Salazar
> > >patazstudio.com
> > >
> > >
> > >
> > >On Tue, Dec 18, 2012 at 5:31 PM, patrick boelens <p_boelens at msn.com>
> > wrote:
> > >
> > >>
> > >> I thought about that, but it seemed weird and cumbersome having to
> > always
> > >> end your file names in .py or .osl before (correct) highlighting can
> > occur.
> > >> (Maybe it's just me being lazy but I never end in either extension when
> > >> working in Blender.) Maybe we could have a combination of the two (keep
> > the
> > >> option, but be smart about it)?
> > >>
> > >> For example:
> > >> - New file  -  syntax = Python
> > >> - Switch to "my_shader.osl"  -  syntax = OSL
> > >> - New file  -  syntax = OSL (persistent from previous file)
> > >>
> > >> -Patrick
> > >>
> > >> > From: zanqdo at gmail.com
> > >> > Date: Tue, 18 Dec 2012 17:13:30 -0600
> > >> > To: bf-committers at blender.org
> > >> > Subject: Re: [Bf-committers] Syntax Highlighting for OSL - Question
> > >> >
> > >> > Sounds good, however I'd prefer the syntax selection be automatic
> > based
> > >> on
> > >> > the extension, like it is already for other things related to py vs
> > osl.
> > >> > One less menu or button is always good!
> > >> >
> > >> > Daniel Salazar
> > >> > patazstudio.com
> > >> >
> > >> >
> > >> >
> > >> > On Tue, Dec 18, 2012 at 5:11 PM, patrick boelens <p_boelens at msn.com>
> > >> wrote:
> > >> >
> > >> > >
> > >> > > Hey everyone,
> > >> > >
> > >> > > I just added a new patch for OSL syntax highlighting in the Text
> > Editor
> > >> > > which I thought people might find useful. Personally I would love a
> > bit
> > >> > > more color variation, which is why I did the request in the code
> > >> comments
> > >> > > of giving decorators their own color, and also why I'll probably
> > give
> > >> OSL's
> > >> > > data types (int, void, closure) a unique one for myself as well. I
> > >> figured
> > >> > > I'd ask here to see how others would feel about having the same
> > added
> > >> in
> > >> > > trunk rather than just tossing it in there along with the rest of my
> > >> patch.
> > >> > >
> > >> > > Hope somebody finds this useful, cheers!
> > >> > > -Patrick
> > >> > >
> > >> > > The patch:
> > >> > > http://projects.blender.org/tracker/index.php?func=detail&aid=33609
> > >> > >
> > >> > > _______________________________________________
> > >> > > Bf-committers mailing list
> > >> > > Bf-committers at blender.org
> > >> > > http://lists.blender.org/mailman/listinfo/bf-committers
> > >> > >
> > >> > _______________________________________________
> > >> > Bf-committers mailing list
> > >> > Bf-committers at blender.org
> > >> > http://lists.blender.org/mailman/listinfo/bf-committers
> > >>
> > >> _______________________________________________
> > >> Bf-committers mailing list
> > >> Bf-committers at blender.org
> > >> http://lists.blender.org/mailman/listinfo/bf-committers
> > >>
> > >_______________________________________________
> > >Bf-committers mailing list
> > >Bf-committers at blender.org
> > >http://lists.blender.org/mailman/listinfo/bf-committers
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
> >
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers