[Bf-committers] Bring back Grease Pencil in Sequencer

[Thomas Dinges]

Hi,
I did some further fixes and cleanup: http://www.pasteall.org/31351/diff

-SEQ_DRAW_GPENCIL flag removed
-added GPencil keymap and removed Animation keymap from the preview 
area, it had overwritten GPencil. (Who wants to slide frames in the 
preview area anyways? oO)
This means, the "D" key works fine now.
-Added missing ND_GPENCIL notifier to the sequencer listener.

Overall this looks good in my opinion.

Still, it draws with a wrong offset to the right/top side. No idea where 
the issue is, but probably in drawgpencil.c where it defines offsx and 
offsy.

Regards,
Thomas

Am 29.04.2012 18:33, schrieb Thomas Dinges:
> Hi thanks for the reply. :)
>
> Am 29.04.2012 18:13, schrieb Joshua Leung:
>> Hi,
>>
>> It's cool to see someone looking into this. I almost forgot about it actually.
>>
>> Regarding the remaining issues:
>> 1) It's probably a missing keymap? I don't see any mention of the
>> standard grease pencil keymap being added to the keymap sets for the
>> relevant sequencer regions?
> Probably, I have not checked it yet.
>> 2) Weird. Which region within the sequencer were you trying it on? It
>> was only designed to work for the Preview region, though the specifics
>> of that may have changed (for the better).
> I tried it only in the Preview area, after I added an image or video strip.
>> Other things:
>> - The "Use Grease Pencil" option isn't actually used anywhere else
>> anymore. Is there anyone who'd really like to see this come back? I'm
>> under the impression that it was actually more bureaucracy than
>> anything useful/productive.
>> - Since Grease Pencil is only for the Image preview, shouldn't this
>> menu item go under that section (if it were to exist)?
> I just ported it, because it was still there. But can be removed.
>
> Regards,
> Thomas
>> Regards,
>> Joshua
-- 
Thomas Dinges
Blender Developer, Artist and Musician

www.dingto.org