[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [45691] trunk/blender/release/scripts/ startup/bl_operators/uvcalc_lightmap.py: Fix #30968: Lightmap Pack - no new image limit

[Sergey Sharybin]

If you'll say lightmap to create new image you can not undo properly.
Probably it's better to undo something than preventing undoing anything
here, but its not the only operator which was forbidden to do this. Proper
solution would be make undo stack support changes of non-mesh data when
object is in edit mode, but for now thought it's ok to deal with such a
limitation (for me it seems not so confusing as infinite generating of
images)

On Mon, Apr 16, 2012 at 5:57 PM, Campbell Barton <ideasman42 at gmail.com>wrote:

> Don't think this is correct, as with other unwrap operations - you
> should be able to undo them at least.
>
> On Mon, Apr 16, 2012 at 9:54 PM, Sergey Sharybin <sergey.vfx at gmail.com>
> wrote:
> > Revision: 45691
> >
> http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=45691
> > Author:   nazgul
> > Date:     2012-04-16 11:54:28 +0000 (Mon, 16 Apr 2012)
> > Log Message:
> > -----------
> > Fix #30968: Lightmap Pack - no new image limit
> >
> > Disable operator register and redo flags because it might modify non-mesh
> > data when in edit mode. This doesn't work properly with current undo
> stack
> > design.
> >
> > Modified Paths:
> > --------------
> >    trunk/blender/release/scripts/startup/bl_operators/uvcalc_lightmap.py
> >
> > Modified:
> trunk/blender/release/scripts/startup/bl_operators/uvcalc_lightmap.py
> > ===================================================================
> > ---
> trunk/blender/release/scripts/startup/bl_operators/uvcalc_lightmap.py
> 2012-04-16 11:03:42 UTC (rev 45690)
> > +++
> trunk/blender/release/scripts/startup/bl_operators/uvcalc_lightmap.py
> 2012-04-16 11:54:28 UTC (rev 45691)
> > @@ -549,7 +549,6 @@
> >     '''Follow UVs from active quads along continuous face loops'''
> >     bl_idname = "uv.lightmap_pack"
> >     bl_label = "Lightmap Pack"
> > -    bl_options = {'REGISTER', 'UNDO'}
> >
> >     PREF_CONTEXT = bpy.props.EnumProperty(
> >             name="Selection",
> >
> > _______________________________________________
> > Bf-blender-cvs mailing list
> > Bf-blender-cvs at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>
>
>
> --
> - Campbell
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>



-- 
With best regards, Sergey Sharybin