[Bf-committers] Weight Paint Ready for Review (radish branch)

Campbell Barton ideasman42 at gmail.com
Thu Sep 15 15:11:24 CEST 2011


Talked with Sergey about the weight paint branch and heres how we'd
like to move forward with merging into trunk.

We both reviewed the code and theres enough fixes and improvements to
make, but nothing blocking.
Give Jason until September the 19th to address the issues from the
CodeReview (5 days should be enough, we can help too if he has any
troubles), then do final cleanup and merge.

There are 2 things that will remain commented.

- Tool to correct distortion in vertex groups, forces modifier
recalculation per vertex in an inefficient way.
- Changes to pose bone selection behavior (works like Shift is always held).

- Campbell

On Thu, Sep 15, 2011 at 3:57 PM, Campbell Barton <ideasman42 at gmail.com> wrote:
> Yep, needs to be done before merge, should have mentioned that.
>
> On Thu, Sep 15, 2011 at 3:46 PM, Thomas Dinges <blender at dingto.org> wrote:
>> Hi,
>> could we remove all these "Jason was here" or "Jason" comments inside
>> the code?
>>
>> Regards,
>> Thomas
>>
>> Am 15.09.2011 04:13, schrieb Campbell Barton:
>>> Heres the code review post containing a patch which applies on latest
>>> trunk (r40212)
>>>
>>> Code Review Page:
>>> http://codereview.appspot.com/5021044
>>>
>>> Patch for trunk:
>>> http://codereview.appspot.com/download/issue5021044_1.diff
>>>
>>> Most of my review and edits have been on the code: syncing with trunk,
>>> moving bad level calls into BKE, some UI tweaks + removing some
>>> warnings and fixes.
>>> I've left the functionality unchanged from the final GSOC project
>>> since I think its better to do that as apart of the review.
>>>
>>> To avoid complaints after merging, I'd like it if some users can apply
>>> the patch on trunk and test it to give some user level feedback.
>>>
>>> Jasons's GSOC info:
>>>
>>> Jason Hays, Weighting tools
>>> - log: http://wiki.blender.org/index.php?title=User:Jason_hays22/GSoC-2011
>>> - video: http://www.youtube.com/watch?v=_NFVGzvODNw
>>> - video: http://www.youtube.com/watch?v=I79Q6sOWnaE
>>>
>>
>>
>> --
>> Thomas Dinges
>> Blender Developer, Artist and Musician
>>
>> www.dingto.org
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>
>
>
> --
> - Campbell
>



-- 
- Campbell


More information about the Bf-committers mailing list