[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [41550] trunk/blender: Disable x-mirror option when proportional edit is enabled.

[Martin Poirier]

It's not a matter of not confusing users, it's broken, period. There's only very limited conditions where it would actual work and not have very unexpected behaviour (like part of the mesh staying fixed in place for example).

The only way to fix this is to redo the x-mirror feature.


Of course, feel free to enable it in a local build if you want, but don't complain when it doesn't do what you want.


Martin



________________________________
From: Daniel Salazar - 3Developer.com <zanqdo at gmail.com>
To: bf-committers at blender.org
Sent: Saturday, November 5, 2011 11:46:20 AM
Subject: Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [41550] trunk/blender: Disable x-mirror option when proportional edit is enabled.

I miss this.. should not be disabled in the sake of not confusing
users, isn't there a better way? no warning and breaking mirror when
you expect it to work is worst. maybe there's a compromise. i hope so
at least!

cheers!

Daniel Salazar
3Developer.com



On Sat, Nov 5, 2011 at 4:19 AM, Sergey Sharybin <g.ulairi at gmail.com> wrote:
> Revision: 41550
>          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=41550
> Author:   nazgul
> Date:     2011-11-05 10:19:36 +0000 (Sat, 05 Nov 2011)
> Log Message:
> -----------
> Disable x-mirror option when proportional edit is enabled.
>
> This option isn't supported because it behaves strangely in 50% of cases and
> hopefully disabled x-mirror will stop users be confused by this.
>
> Modified Paths:
> --------------
>    trunk/blender/release/scripts/startup/bl_ui/space_view3d_toolbar.py
>    trunk/blender/source/blender/editors/space_view3d/space_view3d.c
>
> Modified: trunk/blender/release/scripts/startup/bl_ui/space_view3d_toolbar.py
> ===================================================================
> --- trunk/blender/release/scripts/startup/bl_ui/space_view3d_toolbar.py 2011-11-05 08:40:07 UTC (rev 41549)
> +++ trunk/blender/release/scripts/startup/bl_ui/space_view3d_toolbar.py 2011-11-05 10:19:36 UTC (rev 41550)
> @@ -179,18 +179,21 @@
>         ob = context.active_object
>
>         if ob:
> +            tool_settings = context.tool_settings
>             mesh = ob.data
> +
>             col = layout.column(align=True)
> +            col.active = tool_settings.proportional_edit == 'DISABLED'
>             col.prop(mesh, "use_mirror_x")
> -            sub = col.column()
> -            sub.active = ob.data.use_mirror_x
> -            sub.prop(mesh, "use_mirror_topology")
>
> -            ts = context.tool_settings
> +            row = col.row()
> +            row.active = ob.data.use_mirror_x
> +            row.prop(mesh, "use_mirror_topology")
>
> -            col.label("Edge Select Mode")
> -            col.prop(ts, "edge_path_mode", text="")
> -            col.prop(context.tool_settings, "edge_path_live_unwrap")
> +            col = layout.column(align=True)
> +            col.label("Edge Select Mode:")
> +            col.prop(tool_settings, "edge_path_mode", text="")
> +            col.prop(tool_settings, "edge_path_live_unwrap")
>
>  # ********** default tools for editmode_curve ****************
>
>
> Modified: trunk/blender/source/blender/editors/space_view3d/space_view3d.c
> ===================================================================
> --- trunk/blender/source/blender/editors/space_view3d/space_view3d.c    2011-11-05 08:40:07 UTC (rev 41549)
> +++ trunk/blender/source/blender/editors/space_view3d/space_view3d.c    2011-11-05 10:19:36 UTC (rev 41550)
> @@ -874,6 +874,7 @@
>                                case ND_MODE:
>                                case ND_LAYER:
>                                case ND_LAYER_CONTENT:
> +                               case ND_TOOLSETTINGS:
>                                        ED_region_tag_redraw(ar);
>                                        break;
>                        }
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>
_______________________________________________
Bf-committers mailing list
Bf-committers at blender.org
http://lists.blender.org/mailman/listinfo/bf-committers