[Bf-committers] Sensor Size

[Sergey I. Sharybin]

  Hi,

I've reviewed patch and the only things which are confusing me:
- Vertical sensor size has got no affect
- Exportters also weren't handling sensor size correct (they were using 
default or so)

Problem that it's not actully areas of code i've been working before so 
patch should be reviewed by somebody more familiar with this areas.

I could only say that functionality looks useful for me (due to my 
camera-tracking related job atm) and i haven't noticed serious issues 
with code style.

Ejner Fergo wrote:
> Hola,
>
> I have updated the patch to revision 37009:
> http://projects.blender.org/tracker/index.php?func=detail&aid=24427&group_id=9&atid=127
>
> I have also written a short documentation:
> http://wiki.blender.org/index.php/User:San/Real_Focal_Length
>
> About code review, I think I read that only committers can upload to
> the code review tool? The patch is assigned to Sergey Sharybin
> (nazgul) so hopefully he reads this and have the time to do it. I'm
> aware that GSOC is in full swing, but still think this patch will be
> good to have in 2.58.
>
> I am prepared to work more on importers/exporters and have so far made
> good progress on FBX and .chan and will do my best to make every
> script having to do with cameras work with this new code.
>
> Best regards,
>
> Ejner
>
> On Wed, Apr 27, 2011 at 9:08 AM, "Martin Bürbaum"
> <martin.buerbaum at gmx.at>  wrote:
>> Ejner Fergo<ejnersan at gmail.com>  wrote:
>>> I am of course hopeful to see this get some attention from the
>>> developers, and appreciate you guys seeing the importance of this. I
>>> just don't know how to proceed with this to make an inclusion in trunk
>>> more likely. It would be really nice to hear some opinions from those
>>> with authority.
>> I am not a blender developer (sorry, no authority here), but I think a good start would be to upload the latest patch to the code review tool [1].
>> And link that in the bug tracker. (<? I don't know about the exact procedures here.)
>>
>> Then it's pretty easy to review and comment on the patch, which in turn will speed up its integration into trunk, I presume.
>>
>> Saludos,
>> Martin
>>
>> [1] http://codereview.appspot.com
>> Example Review: http://codereview.appspot.com/4280080
>> Mailing List: http://lists.blender.org/pipermail/bf-codereview/
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>


-- 
With best regards, Sergey I. Sharybin