[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [36704] trunk/blender: Patch [#27344] 300+ New/changed tooltips by Davis Sorenson (dsavi).

Davis Sorenson davis.sorenson at gmail.com
Mon May 16 09:36:13 CEST 2011


Hi,
I submitted the patch, sorry about that. Will remember to try to do one at a
time next time around.

Davis

On Mon, May 16, 2011 at 8:41 AM, Campbell Barton <ideasman42 at gmail.com>wrote:

> While its good to see people work on tooltips and docs in general, can
> you make sure they don't sneak in `fixes` at the same time?
>
> This commit introduces the error:
>
> rna_uiItemR: property not found: WaveModifier.texture_coordinate_object
>
> /dsk/data/src/blender/blender/release/scripts/startup/bl_ui/properties_data_modifier.py:726
>
> It looks like the patch was made from someone having script/binary
> version mismatch so they changed it to reference the old RNA variable
> name.
>
> Ill double check there are no changes made in C too but really the
> review process should pick these things up.
>
> Suggest we tell devs submitting fixes to split up the patch in these cases
> - eg:
> Documentation updates don't also fix bugs, bug fixes don't make style
> improvements.
>
> Maybe link them to this :)
> Open Source Contribution Etiquette:
> http://tirania.org/blog/archive/2010/Dec-31.html
>
>
> On Sun, May 15, 2011 at 5:59 PM, Thomas Dinges <blender at dingto.org> wrote:
> > Revision: 36704
> >
> http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=36704
> > Author:   dingto
> > Date:     2011-05-15 17:59:48 +0000 (Sun, 15 May 2011)
> > Log Message:
> > -----------
> > Patch [#27344] 300+ New/changed tooltips by Davis Sorenson (dsavi).
> Thanks a lot!
> > Reviewed by Tom Musgrove and myself.
> >
> > >From the patch description:
> > ValterVB on #blendercoders submitted a long list of missing tooltips in
> Blender, and I went through the list and added all I knew. After that I
> crowdsourced the rest by putting a spreadsheet on Google docs and having
> people fill in the missing ones that I didn't know. So if there's some weird
> tooltip in there that doesn't make sense, that's why.
> >
> > Thanks to Wolter, spacetug and others on BlenderArtists for contributing
> tooltips.
> >
> > Modified Paths:
> > --------------
> >
>  trunk/blender/release/scripts/startup/bl_ui/properties_data_modifier.py
> >    trunk/blender/source/blender/editors/animation/keyframing.c
> >    trunk/blender/source/blender/editors/interface/interface_templates.c
> >    trunk/blender/source/blender/editors/object/object_edit.c
> >    trunk/blender/source/blender/editors/object/object_modifier.c
> >    trunk/blender/source/blender/editors/physics/physics_pointcache.c
> >    trunk/blender/source/blender/editors/space_image/image_ops.c
> >    trunk/blender/source/blender/editors/uvedit/uvedit_unwrap_ops.c
> >    trunk/blender/source/blender/makesrna/intern/rna_color.c
> >    trunk/blender/source/blender/makesrna/intern/rna_constraint.c
> >    trunk/blender/source/blender/makesrna/intern/rna_key.c
> >    trunk/blender/source/blender/makesrna/intern/rna_material.c
> >    trunk/blender/source/blender/makesrna/intern/rna_mesh.c
> >    trunk/blender/source/blender/makesrna/intern/rna_modifier.c
> >    trunk/blender/source/blender/makesrna/intern/rna_object.c
> >    trunk/blender/source/blender/makesrna/intern/rna_object_force.c
> >    trunk/blender/source/blender/makesrna/intern/rna_particle.c
> >    trunk/blender/source/blender/makesrna/intern/rna_property.c
> >    trunk/blender/source/blender/makesrna/intern/rna_scene.c
> >    trunk/blender/source/blender/makesrna/intern/rna_space.c
> >    trunk/blender/source/blender/makesrna/intern/rna_texture.c
> >    trunk/blender/source/blender/makesrna/intern/rna_world.c
> >
> > Modified:
> trunk/blender/release/scripts/startup/bl_ui/properties_data_modifier.py
> > ===================================================================
> > ---
> trunk/blender/release/scripts/startup/bl_ui/properties_data_modifier.py
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++
> trunk/blender/release/scripts/startup/bl_ui/properties_data_modifier.py
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -723,7 +723,7 @@
> >         if md.texture_coords == 'MAP_UV' and ob.type == 'MESH':
> >             layout.prop_search(md, "uv_layer", ob.data, "uv_textures")
> >         elif md.texture_coords == 'OBJECT':
> > -            layout.prop(md, "texture_coords_object")
> > +            layout.prop(md, "texture_coordinate_object")
> >
> >         layout.separator()
> >
> >
> > Modified: trunk/blender/source/blender/editors/animation/keyframing.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/animation/keyframing.c
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/animation/keyframing.c
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -1360,6 +1360,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Delete Keyframe";
> > +       ot->description= "Remove keyframes on current frame for selected
> object";
> >        ot->idname= "ANIM_OT_keyframe_delete_v3d";
> >
> >        /* callbacks */
> >
> > Modified:
> trunk/blender/source/blender/editors/interface/interface_templates.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/interface/interface_templates.c
>        2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/interface/interface_templates.c
>        2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -461,7 +461,7 @@
> >                        uiButSetNFunc(but, NULL, MEM_dupallocN(template),
> NULL);
> >                }
> >                else {
> > -                       but= uiDefIconBut(block, BUT, 0, ICON_X, 0, 0,
> UI_UNIT_X, UI_UNIT_Y, NULL, 0, 0, 0, 0, "Unlink datablock. Shift + Click to
> set users to zero, data gets not saved");
> > +                       but= uiDefIconBut(block, BUT, 0, ICON_X, 0, 0,
> UI_UNIT_X, UI_UNIT_Y, NULL, 0, 0, 0, 0, "Unlink datablock. Shift + Click to
> set users to zero, data will then not be saved");
> >                        uiButSetNFunc(but, template_id_cb,
> MEM_dupallocN(template), SET_INT_IN_POINTER(UI_ID_DELETE));
> >
> >                        if(RNA_property_flag(template->prop) &
> PROP_NEVER_NULL)
> >
> > Modified: trunk/blender/source/blender/editors/object/object_edit.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/object/object_edit.c
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/object/object_edit.c
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -1689,6 +1689,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Shade Flat";
> > +       ot->description= "Display faces 'smooth' (using vertext
> normals)";
> >        ot->idname= "OBJECT_OT_shade_flat";
> >
> >        /* api callbacks */
> > @@ -1703,6 +1704,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Shade Smooth";
> > +       ot->description= "Display faces 'flat'";
> >        ot->idname= "OBJECT_OT_shade_smooth";
> >
> >        /* api callbacks */
> > @@ -2053,6 +2055,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "New Game Property";
> > +       ot->description= "Create a new property available to the game
> engine";
> >        ot->idname= "OBJECT_OT_game_property_new";
> >
> >        /* api callbacks */
> > @@ -2090,6 +2093,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Remove Game Property";
> > +       ot->description= "Remove game property";
> >        ot->idname= "OBJECT_OT_game_property_remove";
> >
> >        /* api callbacks */
> >
> > Modified: trunk/blender/source/blender/editors/object/object_modifier.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/object/object_modifier.c
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/object/object_modifier.c
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -982,6 +982,7 @@
> >  void OBJECT_OT_multires_higher_levels_delete(wmOperatorType *ot)
> >  {
> >        ot->name= "Delete Higher Levels";
> > +       ot->description= "Deletes the higher resolution mesh, potential
> loss of detail";
> >        ot->idname= "OBJECT_OT_multires_higher_levels_delete";
> >
> >        ot->poll= multires_poll;
> >
> > Modified:
> trunk/blender/source/blender/editors/physics/physics_pointcache.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/physics/physics_pointcache.c
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/physics/physics_pointcache.c
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -156,6 +156,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Bake All Physics";
> > +       ot->description= "Bake all physics";
> >        ot->idname= "PTCACHE_OT_bake_all";
> >
> >        /* api callbacks */
> > @@ -171,6 +172,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Free All Physics Bakes";
> > +       ot->name= "Free all physics bakes";
> >        ot->idname= "PTCACHE_OT_free_bake_all";
> >
> >        /* api callbacks */
> > @@ -268,6 +270,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Bake Physics";
> > +       ot->description= "Bake physics";
> >        ot->idname= "PTCACHE_OT_bake";
> >
> >        /* api callbacks */
> > @@ -283,6 +286,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Free Physics Bake";
> > +       ot->description= "Free physics bake";
> >        ot->idname= "PTCACHE_OT_free_bake";
> >
> >        /* api callbacks */
> > @@ -296,6 +300,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Bake From Cache";
> > +       ot->description= "Bake from cache";
> >        ot->idname= "PTCACHE_OT_bake_from_cache";
> >
> >        /* api callbacks */
> > @@ -364,7 +369,8 @@
> >  void PTCACHE_OT_add(wmOperatorType *ot)
> >  {
> >        /* identifiers */
> > -       ot->name= "Add new cache";
> > +       ot->name= "Add New Cache";
> > +       ot->description= "Add new cache";
> >        ot->idname= "PTCACHE_OT_add";
> >
> >        /* api callbacks */
> > @@ -377,7 +383,8 @@
> >  void PTCACHE_OT_remove(wmOperatorType *ot)
> >  {
> >        /* identifiers */
> > -       ot->name= "Delete current cache";
> > +       ot->name= "Delete Current Cache";
> > +       ot->description= "Delete current cache";
> >        ot->idname= "PTCACHE_OT_remove";
> >
> >        /* api callbacks */
> >
> > Modified: trunk/blender/source/blender/editors/space_image/image_ops.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/space_image/image_ops.c
>  2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/space_image/image_ops.c
>  2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -802,6 +802,7 @@
> >  {
> >        /* identifiers */
> >        ot->name= "Open Image";
> > +       ot->description= "Open image";
> >        ot->idname= "IMAGE_OT_open";
> >
> >        /* api callbacks */
> > @@ -1345,6 +1346,7 @@
> >
> >        /* identifiers */
> >        ot->name= "New Image";
> > +       ot->description= "Create a new image";
> >        ot->idname= "IMAGE_OT_new";
> >
> >        /* api callbacks */
> >
> > Modified: trunk/blender/source/blender/editors/uvedit/uvedit_unwrap_ops.c
> > ===================================================================
> > --- trunk/blender/source/blender/editors/uvedit/uvedit_unwrap_ops.c
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/editors/uvedit/uvedit_unwrap_ops.c
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -893,6 +893,7 @@
> >
> >        /* identifiers */
> >        ot->name= "Unwrap";
> > +       ot->description= "Unwrap the mesh of the object being edited";
> >        ot->idname= "UV_OT_unwrap";
> >        ot->flag= OPTYPE_REGISTER|OPTYPE_UNDO;
> >
> >
> > Modified: trunk/blender/source/blender/makesrna/intern/rna_color.c
> > ===================================================================
> > --- trunk/blender/source/blender/makesrna/intern/rna_color.c
>  2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/makesrna/intern/rna_color.c
>  2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -435,13 +435,13 @@
> >        prop= RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR);
> >        RNA_def_property_float_sdna(prop, NULL, "r");
> >        RNA_def_property_array(prop, 4);
> > -       RNA_def_property_ui_text(prop, "Color", "");
> > +       RNA_def_property_ui_text(prop, "Color", "Set color of selected
> color stop");
> >        RNA_def_property_update(prop, 0, "rna_ColorRamp_update");
> >
> >        prop= RNA_def_property(srna, "position", PROP_FLOAT, PROP_NONE);
> >        RNA_def_property_float_sdna(prop, NULL, "pos");
> >        RNA_def_property_range(prop, 0, 1);
> > -       RNA_def_property_ui_text(prop, "Position", "");
> > +       RNA_def_property_ui_text(prop, "Position", "Set position of
> selected color stop");
> >        RNA_def_property_update(prop, 0, "rna_ColorRamp_update");
> >  }
> >
> >
> > Modified: trunk/blender/source/blender/makesrna/intern/rna_constraint.c
> > ===================================================================
> > --- trunk/blender/source/blender/makesrna/intern/rna_constraint.c
> 2011-05-15 16:42:39 UTC (rev 36703)
> > +++ trunk/blender/source/blender/makesrna/intern/rna_constraint.c
> 2011-05-15 17:59:48 UTC (rev 36704)
> > @@ -75,18 +75,25 @@
> >        {CONSTRAINT_TYPE_SHRINKWRAP, "SHRINKWRAP", ICON_CONSTRAINT_DATA,
> "Shrinkwrap", ""},
> >        {0, NULL, 0, NULL, NULL}};
> >
> > -static EnumPropertyItem space_pchan_items[] = {
> > -       {0, "WORLD", 0, "World Space", ""},
> > -       {2, "POSE", 0, "Pose Space", ""},
> > -       {3, "LOCAL_WITH_PARENT", 0, "Local With Parent", ""},
> > -       {1, "LOCAL", 0, "Local Space", ""},
> > +static EnumPropertyItem target_space_pchan_items[] = {
> > +       {0, "WORLD", 0, "World Space", "The transformation of the target
> is evaluated relative to the world coordinate system"},
> > +       {2, "POSE", 0, "Pose Space", "The transformation of the target is
> only evaluated in the Pose Space, the target armature object transformation
> is ignored"},
> > +       {3, "LOCAL_WITH_PARENT", 0, "Local With Parent", "The
> transformation of the target bone is evaluated relative its local coordinate
> system, with the parent transformation added"},
> > +       {1, "LOCAL", 0, "Local Space", "The transformation of the target
> is evaluated relative to its local coordinate system"},
> >        {0, NULL, 0, NULL, NULL}};
> >
> > +static EnumPropertyItem owner_space_pchan_items[] = {
> > +       {0, "WORLD", 0, "World Space", "The constraint is applied
> relative to the world coordinate system"},
> > +       {2, "POSE", 0, "Pose Space", "The constraint is applied in Pose
> Space, the object transformation is ignored"},
> > +       {3, "LOCAL_WITH_PARENT", 0, "The constraint is applied relative
> to the local coordinate system of the object, with the parent transformation
> added"},
> > +       {1, "LOCAL", 0, "Local Space", "The constraint is applied
> relative to the local coordinate sytem of the object"},
> > +       {0, NULL, 0, NULL, NULL}};
> > +
> >  #ifdef RNA_RUNTIME
> >
> >  static EnumPropertyItem space_object_items[] = {
> > -       {0, "WORLD", 0, "World Space", ""},
> > -       {1, "LOCAL", 0, "Local Space", ""},
> > +       {0, "WORLD", 0, "World Space", "The transformation of the target
> is evaluated relative to the world coordinate system"},
> > +       {1, "LOCAL", 0, "Local Space", "The transformation of the target
> is evaluated relative to its local coordinate system"},
> >        {0, NULL, 0, NULL, NULL}};
> >
> >  #include "BKE_animsys.h"
> > @@ -242,7 +249,7 @@
> >        bConstraint *con= (bConstraint*)ptr->data;
> >
> >
> > @@ Diff output truncated at 10240 characters. @@
> > _______________________________________________
> > Bf-blender-cvs mailing list
> > Bf-blender-cvs at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-blender-cvs
> >
>
>
>
> --
> - Campbell
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>


More information about the Bf-committers mailing list