[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [36451] branches/bmesh/blender: = bmesh version of prior trunk commit=

[joe]

On Mon, May 2, 2011 at 8:41 PM, Campbell Barton <ideasman42 at gmail.com> wrote:
> agree that it should use the current option.
> also, looked over the changes.
>
> - Using a timer for loopcut in this case looks like its not necessary,
> changing how the events behave should be possible without it.

It's not possible, no.  It has to exit after mouse down and a small
delay--but confirm + abort the macro if mouse up happens before then.
That means a timer.

> - Setting the left mouse as an operator property is not good either,
> AFAIK no other operators do this (some store events internally like
> the ones they are activated by, but they don't expose them as operator
> properties).

It's not a real event, it just serves to make transform pay attention
to the release_confirm property.

> - Would prefer changes to the wm & event system be done as separate
> commits (macro abort).
I'll remember that.

> - This also adds 'dsm_maxmem' to the user preferences which isn't used anywhere.

I'll get rid of tha.

> could this commit be reversed?, think it can be implemented better or
> just leave trunk as is and focus on bmesh instead.

It has to happen sometime :) Might as well get it over with now.

>
> On Tue, May 3, 2011 at 2:15 AM, Matt Ebb <matt at mke3.net> wrote:
>> weird, here's the original commit from last year:
>> http://lists.blender.org/pipermail/bf-blender-cvs/2010-April/027513.html
>>
>> In any case, i think it might be better to keep it with the release
>> confirm preference rather than adding a new one for one specific tool
>> only. It goes hand in hand, especially if you're using a tablet etc.

That makes sense.

Joe