[Bf-committers] Bokeh error?

[Lukas Tönne]

Yes, looks like the author took "x ranges from -1 to 1" literally.
Just means the filter function is symmetric, the range in this case
should still be 0..1

On Mon, Jul 11, 2011 at 9:47 AM, j.bakker at atmind.nl <j.bakker at atmind.nl> wrote:
> Bokeh error?
>
> I was looking at the bokeh blur, and think I found a glitch. If you take a
> single pixel and use bokeh blur, you get a donut in stead of a circle.
>
> see http://www.pasteall.org/pic/show.php?id=14809
>
> this is due the formula CMP_blur:
> 390: *dgauss= RE_filter_value(nbd->filtertype, 2.0f*dist - 1.0f);
>
> I think it should just be
> 390: *dgauss= RE_filter_value(nbd->filtertype, dist);
>
> to reflect the non bokeh blur formula.
>
> Is this a bug?
>
> Jeroen Bakker.
>
> --------------------------------------------------------------------
> mail2web.com – What can On Demand Business Solutions do for you?
> http://link.mail2web.com/Business/SharePoint
>
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>