[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [33962] trunk/blender: CMake: use blender_include_dirs("${OPENGL_INCLUDE_DIR}") rather then blender_include_dirs(${OPENGL_INCLUDE_DIR})
Tamito KAJIYAMA
rd6t-kjym at asahi-net.or.jp
Sun Jan 2 22:00:53 CET 2011
Hi Mitchell,
The build with VS and CMake goes straight now. Thanks for the fix!
Regards,
--
KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>
----- Original Message -----
From: "Mitchell Stokes" <mogurijin at gmail.com>
To: "bf-blender developers" <bf-committers at blender.org>
Sent: Sunday, January 02, 2011 10:12 AM
Subject: Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [33962] trunk/blender: CMake: use
blender_include_dirs("${OPENGL_INCLUDE_DIR}") rather then blender_include_dirs(${OPENGL_INCLUDE_DIR})
>> Thanks for the fix! Unfortunately, however, a recent change by Nathan
>> has a negative effect causing a CMake error. On a test environment
>> of mine (64-bit Windows Vista, VS 2008 Pro),
>>
>> It also breaks on Win7 Pro 64bit using VS 2010 Pro.
>
>
>> > if(MSVC)
>> > - include_directories(${OPENGL_INCLUDE_DIR})
>> > + include_directories("${OPENGL_INCLUDE_DIR}")
>> > else()
>> > - blender_include_dirs(${OPENGL_INCLUDE_DIR})
>> > + blender_include_dirs("${OPENGL_INCLUDE_DIR}")
>> > endif()
>>
>> this block should simply be:
>>
>> blender_include_dirs("${OPENGL_INCLUDE_DIR}")
>>
>> without the if-else-endif statement. Hope this change does not break
>> the compilation process in other environments.
>>
>
> If there are no objections, I'll commit the fix suggested by Tamito.
>
> Cheers,
> Mitchell Stokes (Moguri)
More information about the Bf-committers
mailing list