[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [42708] trunk/blender: Removed buttons in node headers for hiding unused sockets and for hiding the (non-socket) option buttons.

[Lukas Tönne]

Ok, i just had a discussion with Daniel and Dalai, who also are not
amused about the removed "hide unused sockets" button ;)

Instead of just adding back this button though, Dalai proposed to add
a more intelligent auto-hide feature: unused sockets are automatically
hidden in collapsed node mode. This seems to be the primary purpose of
the feature, and since neither names nor values are displayed on
collapsed nodes it makes linking more-or-less impossible anyway in
that mode.

I also wouldn't mind having the button in the side bar (nkey) panels.
IMO this is where all the fine-grained detail settings for nodes
should go, that would otherwise take too much space on the node itself
AND are not needed frequently (as in: only clicked once). Future
socket details can also go there too, especially settings for node
group interfaces (but that's a different topic).

Would you be ok with that?

On Sun, Dec 18, 2011 at 9:35 PM, PabloVazquez.org <venomgfx at gmail.com> wrote:
> -1 on removal from UI
>
> Perhaps the node header itself is not the best place for it, but this
> option should still be visible somewhere (a "Display" panel on NKEY
> sidebar or so?).
>
> As an old user, I won't miss it a lot because I use shortcuts for that
> (Ctrl/Shift+H),  but still is a handy option to have somewhere,
> specially when using nodes with many options, like some shader nodes,
> made this example image:
> http://pablovazquez.org/tmp/unused_sockets.gif
>
> Just my 0.2 candy worth cents
> --
> Pablo Vazquez
> CG Artist
> Blender Foundation Certified Trainer
> E-mail: contact at pablovazquez.org
> Website: http://www.pablovazquez.org
>
>
>
> On Sun, Dec 18, 2011 at 14:59, Lukas Toenne <lukas.toenne at googlemail.com> wrote:
>> Revision: 42708
>>          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42708
>> Author:   lukastoenne
>> Date:     2011-12-18 17:59:04 +0000 (Sun, 18 Dec 2011)
>> Log Message:
>> -----------
>> Removed buttons in node headers for hiding unused sockets and for hiding the (non-socket) option buttons. These are rarely used buttons that only complicate the UI. Alternatively these operators can still be accessed in the Node menu of the node editor window, "Toggle Hidden Node Sockets" and "Toggle Node Options" respectively.
>>
>> Modified Paths:
>> --------------
>>    trunk/blender/release/scripts/startup/bl_ui/space_node.py
>>    trunk/blender/source/blender/editors/space_node/node_draw.c
>>
>> Modified: trunk/blender/release/scripts/startup/bl_ui/space_node.py
>> ===================================================================
>> --- trunk/blender/release/scripts/startup/bl_ui/space_node.py   2011-12-18 15:34:06 UTC (rev 42707)
>> +++ trunk/blender/release/scripts/startup/bl_ui/space_node.py   2011-12-18 17:59:04 UTC (rev 42708)
>> @@ -156,6 +156,7 @@
>>         layout.operator("node.mute_toggle")
>>         layout.operator("node.preview_toggle")
>>         layout.operator("node.hide_socket_toggle")
>> +        layout.operator("node.options_toggle")
>>
>>         layout.separator()
>>
>>
>> Modified: trunk/blender/source/blender/editors/space_node/node_draw.c
>> ===================================================================
>> --- trunk/blender/source/blender/editors/space_node/node_draw.c 2011-12-18 15:34:06 UTC (rev 42707)
>> +++ trunk/blender/source/blender/editors/space_node/node_draw.c 2011-12-18 17:59:04 UTC (rev 42708)
>> @@ -642,26 +642,6 @@
>>                uiButSetFunc(but, node_toggle_button_cb, node, (void*)"NODE_OT_group_edit");
>>                uiBlockSetEmboss(node->block, UI_EMBOSS);
>>        }
>> -       /* option buttons */
>> -       if(node->typeinfo->flag & NODE_OPTIONS) {
>> -               uiBut *but;
>> -               iconofs-=iconbutw;
>> -               uiBlockSetEmboss(node->block, UI_EMBOSSN);
>> -               but = uiDefIconBut(node->block, TOGBUT, B_REDR, ICON_BUTS,
>> -                                                  iconofs, rct->ymax-NODE_DY, iconbutw, UI_UNIT_Y, NULL, 0, 0, 0, 0, "");
>> -               uiButSetFunc(but, node_toggle_button_cb, node, (void*)"NODE_OT_options_toggle");
>> -               uiBlockSetEmboss(node->block, UI_EMBOSS);
>> -       }
>> -       /* hide unused sockets */
>> -       {
>> -               uiBut *but;
>> -               iconofs-=iconbutw;
>> -               uiBlockSetEmboss(node->block, UI_EMBOSSN);
>> -               but = uiDefIconBut(node->block, TOGBUT, B_REDR, ICON_PLUS,
>> -                                                  iconofs, rct->ymax-NODE_DY, iconbutw, UI_UNIT_Y, NULL, 0, 0, 0, 0, "");
>> -               uiButSetFunc(but, node_toggle_button_cb, node, (void*)"NODE_OT_hide_socket_toggle");
>> -               uiBlockSetEmboss(node->block, UI_EMBOSS);
>> -       }
>>
>>        /* title */
>>        if(node->flag & SELECT)
>>
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers