[Bf-committers] Asking for help with patch conversion (bas-relief)

Peter K.H. Gragert pkhgragert at gmail.com
Wed Aug 24 19:02:13 CEST 2011


Cambell, forgot to say thanks for the order of files in CMakeList.txt do not
matter, sorry.
Peter

2011/8/24 Peter K.H. Gragert <pkhgragert at gmail.com>

> Hi can some confirm that the bas_relief worked in 2.49, meaning that the
> advanced algorithm C-code does (in 2.49) good computations?  Is there a
> patched Bl 2.49 available for me? Can anyone give me a link?
>
> It is very much interesting to look at how to get it work in Bl 2.59
>
> Biggest problem for me is at this momen NodeBasReliefData nowhere defined,
> I suspect that it could be (from the patch Thomas gave)  that
> bNodeType cmp_node_basrelief= { //loking like a bNode
> has a wrong name, maybe it should be NodeBaseReliefData (trying ;) soon)
> ...
>
> Some else would help too?
>
> Greetings
>       Peter
>
>
>
> 2011/8/24 Campbell Barton <ideasman42 at gmail.com>
>
>> @Peter, order of the C file in the list doesn't matter.
>>
>> working patch here:
>> http://codereview.appspot.com/4924046
>>
>> On Thu, Aug 25, 2011 at 1:46 AM, Peter K.H. Gragert
>> <pkhgragert at gmail.com> wrote:
>> > a lot of errors ;-(  comiling CMP_basrelief  ... will see which I
>> understand
>> > is the order of source files in CMakeLIst.txt important?
>> >
>> > Peter
>> >
>> >
>> > 2011/8/24 Peter K.H. Gragert <pkhgragert at gmail.com>
>> >
>> >> just added ;-)
>> >>
>> >>
>> >> 2011/8/24 Campbell Barton <ideasman42 at gmail.com>
>> >>
>> >>> patch is missing the addition of CMP_basrelief.c in
>> >>> ./source/blender/nodes/CMakeLists.txt
>> >>>
>> >>> On Wed, Aug 24, 2011 at 11:29 PM, Thomas Dinges <blender at dingto.org>
>> >>> wrote:
>> >>> > Hi,
>> >>> > I made the basic 2.5x porting (RNA+UI), any further work has to be
>> done
>> >>> > by someone else. :)
>> >>> >
>> >>> > Regards,
>> >>> > Thomas
>> >>> >
>> >>> > Am 24.08.2011 15:26, schrieb Peter K.H. Gragert:
>> >>> >> Thomas,
>> >>> >> one problem .. CMP_basrelief.c is not under controll of SVN.
>> >>> >> How to solve this (small problem)  and maybe a cmake file has to be
>> >>> >> 'patched' too?
>> >>> >> Without this the compilation went without error message ..
>> >>> >>
>> >>> >>        Peter
>> >>> >>
>> >>> >> 2011/8/24 Peter K.H. Gragert<pkhgragert at gmail.com>
>> >>> >>
>> >>> >>> Hi Thomas,
>> >>> >>> I am using mingw and cmake ... so there may be a difference
>> >>> >>>
>> >>> >>> Because patching I have done was 'by hand' so your advice is half
>> >>> clear to
>> >>> >>> me:
>> >>> >>> Steps:
>> >>> >>> I have the following situation:
>> >>> >>> c:\blendersvn\blender  (contains my SVN trunk)
>> >>> >>> I have your patch from graphisall  starting with line: Index:
>> >>> >>> source/blender/blenkernel/BKE_node.h
>> >>> >>> last line: (more or less) +};
>> >>> >>> this file should be put where with what name? (I suppose  in
>> >>> >>> c:\blendersvn\blender as bas_relief.diff ???)
>> >>> >>> Then opening explorer and (try to find) in the SVN possibilities
>> >>> 'Apply
>> >>> >>> patch'?
>> >>> >>>
>> >>> >>> Indeed, that works, ... I tried yet only asking what may go wrong
>> ...
>> >>> what
>> >>> >>> is shown seems only to be tab (\t or space) diffences ..
>> >>> >>>
>> >>> >>> I think I can go back if neede, so I will jump into the deep water
>> ;-)
>> >>> >>>
>> >>> >>>
>> >>> >>> Peter
>> >>> >>>
>> >>> >>> 2011/8/24 Thomas Dinges<blender at dingto.org>
>> >>> >>>
>> >>> >>>> Hi Peter,
>> >>> >>>> yes the node file causes compile errors here on msvc.
>> >>> >>>> Just make right click on your working in the explorer>  Working
>> Copy>
>> >>> >>>> Apply Patch. Then patch all.
>> >>> >>>>
>> >>> >>>> Regards,
>> >>> >>>> Thomas
>> >>> >>>>
>> >>> >>>> Am 24.08.2011 14:44, schrieb Peter K.H. Gragert:
>> >>> >>>>> Hallo Thomas,
>> >>> >>>>> Im pasteall link steht, das es noch nicht funktioniert ...
>>  (Fehler
>> >>> oder
>> >>> >>>>> geht es schon?)
>> >>> >>>>> Was die Artikel erzaehlen sieht sehr gut aus.
>> >>> >>>>>
>> >>> >>>>> Als (gewesener) Mathematiker sollte ich evtl. helfen koennen ...
>> >>> >>>> Probleme zu
>> >>> >>>>> loesen?
>> >>> >>>>>
>> >>> >>>>> Was sollte man benutzen um das 'patch' ausfuehren zu lassen, hab
>> im
>> >>> >>>> Moment
>> >>> >>>>> (nur) SVN-Tortoise ..
>> >>> >>>>>
>> >>> >>>>> Gruss
>> >>> >>>>>           Peter
>> >>> >>>>>
>> >>> >>>>> 2011/8/24 Thomas Dinges<blender at dingto.org>
>> >>> >>>>>
>> >>> >>>>>> Wrong link: Here is the correct one:
>> >>> >>>> http://www.pasteall.org/24255/diff
>> >>> >>>>>> Am 24.08.2011 11:35, schrieb Thomas Dinges:
>> >>> >>>>>>> Working on it... :)
>> >>> >>>>>>> Will get back to you.
>> >>> >>>>>>>
>> >>> >>>>>>> Am 24.08.2011 10:41, schrieb Vilem Novak:
>> >>> >>>>>>>> Hello,
>> >>> >>>>>>>> several years ago I developed a new compositing node - bas
>> >>> relief.
>> >>> >>>>>>>> I am frequently contacted from people who are asking for
>> builds
>> >>> of
>> >>> >>>> this
>> >>> >>>>>> patch, since it's so far probably still the only free and
>> working
>> >>> >>>>>> implementation of the algorithm.
>> >>> >>>>>>>> Currently, I didn't build blender for a long time and I have
>> no
>> >>> clue
>> >>> >>>> how
>> >>> >>>>>> to convert a 2.49 node to a 2.5 node,
>> >>> >>>>>>>> and don't even have internet connection on my working
>> machine, so
>> >>> >>>>>> getting dependencies e.t.c. working is very hard.
>> >>> >>>>>>>> Is there anybody on the list who would be willing to help
>> with
>> >>> >>>>>> converting/building the old patch? Probably it would just need
>> some
>> >>> >>>> standard
>> >>> >>>>>> RNA-fying process.
>> >>> >>>>>>>> here is all the info and the patch:
>> >>> >>>>>>>>
>> >>> >>>>
>> >>>
>> http://wiki.blender.org/index.php/Doc:Reference/Windows/Nodes/Composite_Nodes#Bas_relief
>> >>> >>>>>>>> here are some sample outputs:
>> >>> >>>>>>>> http://plant.ffa.vutbr.cz/~novak/ContemporaryGods.htm
>> >>> >>>>>>>>
>> >>> >>>>>>>> Thanks
>> >>> >>>>>>>> Vilem
>> >>> >>>>>>>> _______________________________________________
>> >>> >>>>>>>> Bf-committers mailing list
>> >>> >>>>>>>> Bf-committers at blender.org
>> >>> >>>>>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>> >>> >>>>>> --
>> >>> >>>>>> Thomas Dinges
>> >>> >>>>>> Blender Developer, Artist and Musician
>> >>> >>>>>>
>> >>> >>>>>> www.dingto.org
>> >>> >>>>>>
>> >>> >>>>>> _______________________________________________
>> >>> >>>>>> Bf-committers mailing list
>> >>> >>>>>> Bf-committers at blender.org
>> >>> >>>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>> >>> >>>>>>
>> >>> >>>>> _______________________________________________
>> >>> >>>>> Bf-committers mailing list
>> >>> >>>>> Bf-committers at blender.org
>> >>> >>>>> http://lists.blender.org/mailman/listinfo/bf-committers
>> >>> >>>>
>> >>> >>>> --
>> >>> >>>> Thomas Dinges
>> >>> >>>> Blender Developer, Artist and Musician
>> >>> >>>>
>> >>> >>>> www.dingto.org
>> >>> >>>>
>> >>> >>>> _______________________________________________
>> >>> >>>> Bf-committers mailing list
>> >>> >>>> Bf-committers at blender.org
>> >>> >>>> http://lists.blender.org/mailman/listinfo/bf-committers
>> >>> >>>>
>> >>> >>>
>> >>> >> _______________________________________________
>> >>> >> Bf-committers mailing list
>> >>> >> Bf-committers at blender.org
>> >>> >> http://lists.blender.org/mailman/listinfo/bf-committers
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Thomas Dinges
>> >>> > Blender Developer, Artist and Musician
>> >>> >
>> >>> > www.dingto.org
>> >>> >
>> >>> > _______________________________________________
>> >>> > Bf-committers mailing list
>> >>> > Bf-committers at blender.org
>> >>> > http://lists.blender.org/mailman/listinfo/bf-committers
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> - Campbell
>> >>> _______________________________________________
>> >>> Bf-committers mailing list
>> >>> Bf-committers at blender.org
>> >>> http://lists.blender.org/mailman/listinfo/bf-committers
>> >>>
>> >>
>> >>
>> > _______________________________________________
>> > Bf-committers mailing list
>> > Bf-committers at blender.org
>> > http://lists.blender.org/mailman/listinfo/bf-committers
>> >
>>
>>
>>
>> --
>> - Campbell
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>
>


More information about the Bf-committers mailing list