[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [39597] branches/soc-2011-pepper/source/ blender/editors/screen/screen_ops.c: Improved hotkeys for frame/keyframe/ jumping

[Joshua Leung]

Page Up/Down is already taken for some other stuff (e.g. Outliner
"page" scroll) which would otherwise get overridden (unless I'm
remembering the keymap evaluation order again; it's changed more times
over the course of 2.5 development than politicians flip-flop over
issues)

On Mon, Aug 22, 2011 at 1:30 PM, Daniel Salazar - 3Developer.com
<zanqdo at gmail.com> wrote:
> I agree on this very much, however, why not using just pageup/down for
> 10steps? why the shift?
>
> cheers
> Daniel Salazar
> 3Developer.com
>
>
>
> On Sun, Aug 21, 2011 at 7:22 PM, Joshua Leung <aligorith at gmail.com> wrote:
>> Revision: 39597
>>          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=39597
>> Author:   aligorith
>> Date:     2011-08-22 01:22:14 +0000 (Mon, 22 Aug 2011)
>> Log Message:
>> -----------
>> Improved hotkeys for frame/keyframe/jumping
>>
>> Thanks pepeland and 3duan for the suggestions. I've been looking at
>> improving these for a while...
>>
>> * Left/Right Arrow = Single Frame stepping as before
>> * Up/Down Arrow = Jumps to next/previous keyframe (used to be the
>> uncomfortable Shift PageUp/Down)
>> * Shift Up/Down Arrow = Jumps forward/back in 10 frame increments
>> (used to be Up/Down Arrows). 10 frame increment should get
>> customisable again as in 2.4, but need to find some UI space to put
>> that!
>> * Ctrl Shift Up/Down/Left/Right = Jump to start/end frame (used to be
>> Shift <Arrow Key>)
>>
>> Modified Paths:
>> --------------
>>    branches/soc-2011-pepper/source/blender/editors/screen/screen_ops.c
>>
>> Modified: branches/soc-2011-pepper/source/blender/editors/screen/screen_ops.c
>> ===================================================================
>> --- branches/soc-2011-pepper/source/blender/editors/screen/screen_ops.c 2011-08-22 00:40:25 UTC (rev 39596)
>> +++ branches/soc-2011-pepper/source/blender/editors/screen/screen_ops.c 2011-08-22 01:22:14 UTC (rev 39597)
>> @@ -3471,21 +3471,21 @@
>>        keymap= WM_keymap_find(keyconf, "Frames", 0, 0);
>>
>>        /* frame offsets */
>> -       RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", UPARROWKEY, KM_PRESS, 0, 0)->ptr, "delta", 10);
>> -       RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", DOWNARROWKEY, KM_PRESS, 0, 0)->ptr, "delta", -10);
>> +       RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", UPARROWKEY, KM_PRESS, KM_SHIFT, 0)->ptr, "delta", 10);
>> +       RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", DOWNARROWKEY, KM_PRESS, KM_SHIFT, 0)->ptr, "delta", -10);
>>        RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", LEFTARROWKEY, KM_PRESS, 0, 0)->ptr, "delta", -1);
>>        RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", RIGHTARROWKEY, KM_PRESS, 0, 0)->ptr, "delta", 1);
>>
>>        RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", WHEELDOWNMOUSE, KM_PRESS, KM_ALT, 0)->ptr, "delta", 1);
>>        RNA_int_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_offset", WHEELUPMOUSE, KM_PRESS, KM_ALT, 0)->ptr, "delta", -1);
>>
>> -       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", UPARROWKEY, KM_PRESS, KM_SHIFT, 0)->ptr, "end", 1);
>> -       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", DOWNARROWKEY, KM_PRESS, KM_SHIFT, 0)->ptr, "end", 0);
>> -       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", RIGHTARROWKEY, KM_PRESS, KM_SHIFT, 0)->ptr, "end", 1);
>> -       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", LEFTARROWKEY, KM_PRESS, KM_SHIFT, 0)->ptr, "end", 0);
>> +       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", UPARROWKEY, KM_PRESS, KM_CTRL|KM_SHIFT, 0)->ptr, "end", 1);
>> +       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", DOWNARROWKEY, KM_PRESS, KM_CTRL|KM_SHIFT, 0)->ptr, "end", 0);
>> +       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", RIGHTARROWKEY, KM_PRESS, KM_CTRL|KM_SHIFT, 0)->ptr, "end", 1);
>> +       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_frame_jump", LEFTARROWKEY, KM_PRESS, KM_CTRL|KM_SHIFT, 0)->ptr, "end", 0);
>>
>> -       WM_keymap_add_item(keymap, "SCREEN_OT_keyframe_jump", PAGEUPKEY, KM_PRESS, KM_CTRL, 0);
>> -       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_keyframe_jump", PAGEDOWNKEY, KM_PRESS, KM_CTRL, 0)->ptr, "next", 0);
>> +       WM_keymap_add_item(keymap, "SCREEN_OT_keyframe_jump", UPARROWKEY, KM_PRESS, 0, 0);
>> +       RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_keyframe_jump", DOWNARROWKEY, KM_PRESS, 0, 0)->ptr, "next", 0);
>>
>>        WM_keymap_add_item(keymap, "SCREEN_OT_keyframe_jump", MEDIALAST, KM_PRESS, 0, 0);
>>        RNA_boolean_set(WM_keymap_add_item(keymap, "SCREEN_OT_keyframe_jump", MEDIAFIRST, KM_PRESS, 0, 0)->ptr, "next", 0);
>>
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>