[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [36228] trunk/blender/source/blender/ blenkernel/intern/object.c: Fix for [#27038] Bugs when linking particles/ collision/softbody modifiers

[bjornmose]

Pleased to see the swamp addressed ..
did not do homework for now,
that is: ->  follow every detail in 2.5 2.6xx development, but kept 
build systems running (as Lunix and some Windoofs  versions .. can't 
tell which one is more insane .. but that would be another topic )
for some limit in my time schedule I did  not follow the entire progress.
A first glance over the topic would suggest:
classify modifiers in
1 crop only
2 crop and generate something DAG has to care for
3 crop and deliver .. well DAG should care for too .. plus resolve circles
.....
will do homework ASAP ..
and be sure me eagle eyes is on it  :)
reads .. I'd be more than happy, if I can help  to resolve that mess..
Kudos
BM



Am 19.04.2011 18:30, schrieb Janne Karhu:
> Revision: 36228
>            http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=36228
> Author:   jhk
> Date:     2011-04-19 16:30:55 +0000 (Tue, 19 Apr 2011)
> Log Message:
> -----------
> Fix for [#27038] Bugs when linking particles/collision/softbody modifiers
> * Collision modifiers are disabled here by intention, but particles and softbody were copied the wrong way over :)
> * On a further note I don't really get this whole "link modifiers" thing as it just copies the modifiers. As modifiers aren't ID blocks there's no sense in calling this linking!
> * Secondly I don't think particles, smoke etc should be considered as modifiers here at all, meaning they shouldn't be linked/copied. These "modifiers" only read the mesh data at a certain location of the stack, but don't actually modify the mesh in any way (more info here http://wiki.blender.org/index.php/User:Jhk#Modifier_Stack_proposal).
>
> Modified Paths:
> --------------
>      trunk/blender/source/blender/blenkernel/intern/object.c
>
> Modified: trunk/blender/source/blender/blenkernel/intern/object.c
> ===================================================================
> --- trunk/blender/source/blender/blenkernel/intern/object.c	2011-04-19 15:15:50 UTC (rev 36227)
> +++ trunk/blender/source/blender/blenkernel/intern/object.c	2011-04-19 16:30:55 UTC (rev 36228)
> @@ -208,8 +208,8 @@
>   		BLI_addtail(&ob->modifiers, nmd);
>   	}
>
> -	copy_object_particlesystems(from, ob);
> -	copy_object_softbody(from, ob);
> +	copy_object_particlesystems(ob, from);
> +	copy_object_softbody(ob, from);
>
>   	// TODO: smoke?, cloth?
>   }
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>