[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [32641] trunk/blender/source/blender: fix warnings

[Tamito KAJIYAMA]

Campbell and Nathan,

With the VC 2008 64-bit compiler and CMake, blenkernel/intern/ipo.c
does not compile due to a warning treated as an error.

1>Compiling...
1>ipo.c
1>..\..\..\..\trunk\source\blender\blenkernel\intern\ipo.c(1191) : error C2220: warning treated as error - no 'object' file 
generated
1>..\..\..\..\trunk\source\blender\blenkernel\intern\ipo.c(1191) : warning C4018: '<' : signed/unsigned mismatch
1>..\..\..\..\trunk\source\blender\blenkernel\intern\ipo.c(1193) : warning C4018: '<' : signed/unsigned mismatch

In revision 32629, Nathan fixed the warning as part of enabling /WX option
(for treating all warnings as errors).  The fix was to have the types of two
variables involved (b and totbits) mached.  In revision 32641, Campbell fixed
warnings, which resulted in type mismatch of the two variables and caused
the error above.  I have no idea about how to resolve this conflict.  Could you
two please deal with it?

Thanks,

-- 
KAJIYAMA, Tamito <rd6t-kjym at asahi-net.or.jp>


----- Original Message ----- 
From: "Campbell Barton" <ideasman42 at gmail.com>
To: <bf-blender-cvs at blender.org>
Sent: Thursday, October 21, 2010 11:45 PM
Subject: [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [32641] trunk/blender/source/blender: fix warnings


> Revision: 32641
>          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=32641
> Author:   campbellbarton
> Date:     2010-10-22 00:45:54 +0200 (Fri, 22 Oct 2010)
>
> Log Message:
> -----------
> fix warnings
>
> Modified Paths:
> --------------
>    trunk/blender/source/blender/blenkernel/intern/collision.c
>    trunk/blender/source/blender/blenkernel/intern/ipo.c
>    trunk/blender/source/blender/blenlib/BLI_kdopbvh.h
>    trunk/blender/source/blender/blenlib/intern/BLI_kdopbvh.c
>    trunk/blender/source/blender/editors/curve/editcurve.c

<snip>

> Modified: trunk/blender/source/blender/blenkernel/intern/ipo.c
> ===================================================================
> --- trunk/blender/source/blender/blenkernel/intern/ipo.c 2010-10-21 22:30:34 UTC (rev 32640)
> +++ trunk/blender/source/blender/blenkernel/intern/ipo.c 2010-10-21 22:45:54 UTC (rev 32641)
> @@ -1123,7 +1123,8 @@
> {
>  AdrBit2Path *abp;
>  FCurve *fcu;
> - unsigned int i=0, totbits;
> + unsigned int i=0;
> + int totbits;
>
>  /* allocate memory for a new F-Curve */
>  fcu= MEM_callocN(sizeof(FCurve), "FCurve");