[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender  trunk/blender: * Assign weight from bones in weight paint mode now respects paint face
matt at mke3.net
Mon Nov 29 03:17:32 CET 2010
On Tue, Mar 30, 2010 at 11:01 PM, Brecht Van Lommel <brecht at blender.org> wrote:
> Revision: 27865
> Author: blendix
> Date: 2010-03-30 14:01:17 +0200 (Tue, 30 Mar 2010)
Hi Brecht, was debugging a volume render bug and found an issue in
rayobject.cpp introduced in the above quoted commit.
In that commit it changes the raytrace 'skip' behaviour from checking
multiple bitflags successively, to treating the bitflags like mutually
exclusive options. I don't think this is the original intention of
this code, since in multiple places in the source (eg. rayshade.c and
also the volume render stuff) the is.skip is set to multiple bitflags.
This has the side effect in the case of:
is.skip = RE_SKIP_VLR_RENDER_CHECK | RE_SKIP_VLR_NON_SOLID_MATERIAL;
ignoring the second flag, since (is->skip & RE_SKIP_VLR_RENDER_CHECK) is true.
removing RE_SKIP_VLR_RENDER_CHECK makes this volume code work
properly, but I suspect that may not be what we want - it still seems
dodgy. If these are now meant to be mutually exclusive options, they
should probably be represented that way in the code, rather than
More information about the Bf-committers