[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [29292] branches/soc-2010-jwilkins/source/ blender/editors/mesh/editmesh_tools.c: fix to bug - [#20084] merging two triangle to a quad creates a hole.

Campbell Barton ideasman42 at gmail.com
Tue Jun 8 12:10:36 CEST 2010


Not sure what to do in this case, Briggs is the official maintainer
but not active these days.

Briggs and I spent some time tweaking the tri 2 quad tool and I can
say for sure that flipping normals is not a good pre-process since you
may run this tool on an entire mesh which correct normals, some
importers only load in triangles but have correctly set normals so you
dont want them recalculated.

This is a branch so one could argue that its OK, however we also want
to merge GSOC branches in eventually so...

1) Give it a comment eg.
// XXX, this is needed for testing for GSOC project, DO NOT MERGE

2) have the maintainer agree this is an acceptable change.

3) remove it.

Otherwise we have changes in branches that will be merged into trunk,
or I have to remember to remove it once its merged, I really don't
think this is a good habit to get into.

On Mon, Jun 7, 2010 at 10:17 AM, Campbell Barton <ideasman42 at gmail.com> wrote:
> don't think this is an acceptable solution since it flips 2 triangles
> with the same normals.
> better not to join them at all of when their normals don't match.
>
> On Mon, Jun 7, 2010 at 4:12 AM, Tom Musgrove <LetterRip at gmail.com> wrote:
>> Revision: 29292
>>          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=29292
>> Author:   letterrip
>> Date:     2010-06-07 04:12:54 +0200 (Mon, 07 Jun 2010)
>>
>> Log Message:
>> -----------
>> fix to bug - [#20084] merging two triangle to a quad creates a hole.
>>
>> Modified Paths:
>> --------------
>>    branches/soc-2010-jwilkins/source/blender/editors/mesh/editmesh_tools.c
>>
>> Modified: branches/soc-2010-jwilkins/source/blender/editors/mesh/editmesh_tools.c
>> ===================================================================
>> --- branches/soc-2010-jwilkins/source/blender/editors/mesh/editmesh_tools.c     2010-06-07 00:21:05 UTC (rev 29291)
>> +++ branches/soc-2010-jwilkins/source/blender/editors/mesh/editmesh_tools.c     2010-06-07 02:12:54 UTC (rev 29292)
>> @@ -7113,6 +7113,7 @@
>>        Object *obedit= CTX_data_edit_object(C);
>>        EditMesh *em= BKE_mesh_get_editmesh((Mesh *)obedit->data);
>>
>> +       EM_recalc_normal_direction(em, 0, 1); /* recalc outside so that joining doesn't create a hole */
>>        join_triangles(em);
>>
>>        DAG_id_flush_update(obedit->data, OB_RECALC_DATA);
>>
>>
>> _______________________________________________
>> Bf-blender-cvs mailing list
>> Bf-blender-cvs at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>>
>
>
>
> --
> - Campbell
>



-- 
- Campbell


More information about the Bf-committers mailing list