[Bf-committers] Patch for "Bump Map Preview" submitted. Please Review!

[Konrad Wilhelm Kleine]

Hi Fredrik,

I've updated the patch with your suggestions since they worked for me,
too. Thank you very much!

-Konrad

Am 30.07.2010 20:22, schrieb Fredrik hansson:
> almost perfect now it really just requires one line of code to be changed.
> the issue now is that the bump is clamped between -1 and 1 in the glsl part but the render isn't.
> http://www.pasteall.org/14682/diff here is what i changed to make it look pretty much identical even outside the -1->1 range 
> 
> --- On Thu, 7/29/10, Konrad Wilhelm Kleine <konrad at konradwilhelm.de> wrote:
> 
>> From: Konrad Wilhelm Kleine <konrad at konradwilhelm.de>
>> Subject: [Bf-committers] Patch for "Bump Map Preview" submitted. Please Review!
>> To: "bf-blender developers" <bf-committers at blender.org>
>> Date: Thursday, July 29, 2010, 7:14 AM
>> Hello,
>>
>> I've modified my patch and fixed all the bugs that were
>> reported to me.
>>
>> The GLSL preview of bump maps looks much like the final
>> render as it can
>> be seens here:
>> http://wiki.blender.org/index.php/User:Kwk/Gsoc2010/BumpMapPainting#Screen_shot
>>
>> I've also removed the additional checkbox that set my
>> shader active.
>> Instead my patch integrates seamlessly. You only need to
>> enable the
>> "Normal" checkbox under Texture -> Influence ->
>> Geometry and have your
>> 3D view rendered by GLSL (Shading mode).
>>
>> I'd would be really happy if you review and accept my
>> patch!
>>
>> Tracker URL:
>> http://projects.blender.org/tracker/index.php?func=detail&aid=23084&group_id=9&atid=127
>>
>> -Konrad
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
> 
> 
>       
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>