[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [30899] trunk/blender: 2.5: remove vertex normal flip option, this is more harmful than helpful

[Matt Ebb]

On 30/07/2010, at 23:38 , Brecht Van Lommel wrote:

> On Fri, Jul 30, 2010 at 3:26 PM, Matt Ebb <matt at mke3.net> wrote:
>> 
>> On 30/07/2010, at 21:50 , Brecht Van Lommel wrote:
>>> Log Message:
>>> -----------
>>> 2.5: remove vertex normal flip option, this is more harmful than helpful
>>> in many cases, and also gave incorrect rim lighting.
>> 
>> Hi brecht, shi->flippednor is now forced to zero it seems, but it is still used in a few places (volume render, to determine if you're looking at the inside of a volume) and also in geometry node front/back. Is it safe to just replace these with a dot product, or was the normal flipping code more complex than that?
> 
> The normal flipping is now done in shade_input_set_normals, calling
> shade_input_flip_normals, which will set shi->flippednor.

oh, right you are, i see now. thanks!

Matt