[Bf-committers] Patch for "Bump map painting preview". Please, review

[Konrad Wilhelm Kleine]

Hi Tom and Hi Frederik,

@Tom
I've uploaded a new working version of the patch and an example blend
file here:
http://wiki.blender.org/index.php/User:Kwk/Gsoc2010/BumpMapPainting#Patch

@Frederik:
Thank you for the fix. I could simplify the code even more because the
normal didn't need to be a vec4 but vec3.

Thank you both very much for reviewing my patch and trying it out!!!

I've updated the wiki page to reflect all the changes and I've added a
link to the discussion on BlenderArtists.org
(http://wiki.blender.org/index.php/User:Kwk/Gsoc2010/BumpMapPainting)
which was opened by Sam V. Thank you Sam!

Is there something else I can to to get my patch accepted?

-Konrad

Am 26.07.2010 17:52, schrieb Tom M:
> > Ok here is the error in the console,
> >
> > I had made the change in the patch recommended by someone else so i
> > might have introduced a bug then...
> >
> > . done
> > GPUShader: compile error:
> > ERROR: 0:1080: 'f' : syntax error syntax error
> >
> >
> > Will revert the change and see if that fixes it.
> >
> > On Mon, Jul 26, 2010 at 7:43 AM, Tom M <letterrip at gmail.com> wrote:
>> >> could you send over a test blend file?
>> >>
>> >> I'm not sure if I'm setting something up wrong or what, but all i get
>> >> is the cube shown as orange.
>> >>
>> >> LetterRip
>> >>
>> >> On Mon, Jul 26, 2010 at 1:23 AM, Konrad Wilhelm Kleine
>> >> <konrad at konradwilhelm.de> wrote:
>>> >>> Hi,
>>> >>>
>>> >>> I've managed to get bump map painting working using the technique we
>>> >>> talked about during yesterdays developer meeting: Generating normal
>>> >>> values from a height map using a Height2Normal GLSL shader.
>>> >>>
>>> >>> I would really appreciate every feedback, or bug report, or feature
>>> >>> request I can get for this patch!
>>> >>>
>>> >>> You can find more information here:
>>> >>>
>>> >>> Design document:
>>> >>> http://wiki.blender.org/index.php/User:Kwk/Gsoc2010/BumpMapPainting
>>> >>>
>>> >>> Video:
>>> >>> http://vimeo.com/13639081
>>> >>>
>>> >>> Patch:
>>> >>> http://www.pasteall.org/14573/diff
>>> >>>
>>> >>> Cheers,
>>> >>> -Konrad
>>> >>> _______________________________________________
>>> >>> Bf-committers mailing list
>>> >>> Bf-committers at blender.org
>>> >>> http://lists.blender.org/mailman/listinfo/bf-committers
>>> >>>
>> >>
> >


Am 26.07.2010 16:12, schrieb Fredrik hansson:
> first off i love the ability to paint bumpmaps directly without having to render :D
> but i did notice a small bug in the way you generate the normals as shown here http://img834.imageshack.us/img834/6781/bump.jpg its quite simple to fix it i have actually gone ahead and done that myself.
> http://www.pasteall.org/14583/cpp lines 15 and 17 are the ones i changed.
> http://img530.imageshack.us/img530/2142/bump2.jpg this is how it looks after those changes.
> 
> now i do have one request with this a simple value controlling the strength of the bump as it can feel a bit weak at times.
> 
> 
> --- On Mon, 7/26/10, Konrad Wilhelm Kleine <konrad at konradwilhelm.de> wrote:
> 
>> From: Konrad Wilhelm Kleine <konrad at konradwilhelm.de>
>> Subject: [Bf-committers] Patch for "Bump map painting preview". Please, review
>> To: "bf-blender developers" <bf-committers at blender.org>
>> Date: Monday, July 26, 2010, 5:23 AM
>> Hi,
>>
>> I've managed to get bump map painting working using the
>> technique we
>> talked about during yesterdays developer meeting:
>> Generating normal
>> values from a height map using a Height2Normal GLSL
>> shader.
>>
>> I would really appreciate every feedback, or bug report, or
>> feature
>> request I can get for this patch!
>>
>> You can find more information here:
>>
>> Design document:
>> http://wiki.blender.org/index.php/User:Kwk/Gsoc2010/BumpMapPainting
>>
>> Video:
>> http://vimeo.com/13639081
>>
>> Patch:
>> http://www.pasteall.org/14573/diff
>>
>> Cheers,
>> -Konrad
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
> 
> 
>       
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>