[Bf-committers] Strange Warning in Bullet - CcdPhysicsController.cpp

[joe]

if (condition); { } means the code in the { } block will always be
executed.  This does look like an error to me.

Joe

On Wed, Feb 3, 2010 at 6:19 AM, Campbell Barton <ideasman42 at gmail.com> wrote:
> sorry for not responding earlier. are you sure this was to fix a bug?
> looks like my own error made r21908.
>
> On Fri, Jan 29, 2010 at 2:37 PM, Benoit Bolsee <benoit.bolsee at online.be> wrote:
>> It is not an error, it was done on purpose to fix some collision bug
>> when replacing a mesh.
>> But I agree that this is extremely confusing, it's probably a quick fix
>> that was left in.
>> The if test should be removed completely.
>>
>> /benoit
>>
>> At Date: Fri, 29 Jan 2010 10:46:16 +0100 J?r?me Lelong
>> <arsouilleur at gmail.com> wrote:
>>> Hi,
>>>
>>> MSVC complain about a strange warning which is propably an
>>> error code: Around line 550 of CcdPhysicsController.cpp in
>>> function ReplaceControllerShape we can find :
>>>
>>> for(int i= 0; i < obarr.size(); i++) {
>>> ob= obarr[i];
>>> if (ob->getCollisionShape() == newShape); {
>>>  proxy = ob->getBroadphaseHandle();
>>>
>>>  if(proxy)
>>> dw->getPairCache()->cleanProxyFromPairs(proxy,dw->getDispatcher());
>>>  }
>>> }
>>>
>>> At the of the first "if", the semicolon seems to be an error.
>>>
>>>
>>>  Arsouille
>>>
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>>
>
>
>
> --
> - Campbell
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>