[Bf-committers] SVN Commit 26478 Break MSVC compil

[Arystan Dyussenov]

Hi,

Indeed this broke cmake+vc build on windows. I put quotes back around
${CMAKE_BUILD_TYPE}.

Thanks!

Arystan

On Tue, Feb 2, 2010 at 7:28 PM, Jérôme Lelong <arsouilleur at gmail.com> wrote:

>  Hi,
>
> Seems that commit 26478 break compil blender on Msvc.
>
> In file /trunk/blender/source/creator/CMakeLists.txt the line
>
>   ADD_DEFINITIONS(-DBUILD_TYPE="${CMAKE_BUILD_TYPE}")
>
> has been replace by
>
>   ADD_DEFINITIONS(-DBUILD_TYPE=${CMAKE_BUILD_TYPE})
>
> In CMake documentation, we ca found :
> "Note that CMAKE_BUILD_TYPE is not initialized with a readable value
> at configuration time. This is because the user is free to select a
> build type at build time."
>
> Then in file c:\blendersvn\blender\source\creator\buildinfo.c : const
> char * build_type=STRINGIFY(BUILD_TYPE);
> BUILD_TYPE is empty and MACRO can't expand.
>
> Arsouille
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>