[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [33578] trunk/blender/source/blender/ editors/curve: Related to previous commit:
Campbell Barton
ideasman42 at gmail.com
Sun Dec 12 03:29:11 CET 2010
@Doug, a more interactive way to change these could be good but I
don't think this is all that simple to add in.
The problem is 2.4x wasn't able to hide curves, so Hkey was used to
change handle types.
Sergio and I discussed the conflict and agreed handle types could be
moved into a menu because of the current haphazard layout for changing
handle types.
We are currently trying to stay 2.4x compatible keymap for the
most-part, yet there are quite a few minor changes since Tkey is now
toolbar, Ckey is now circle select.
Its understandable that Ton comes back to development and finds
keymaps he doesn't like and wants to change back but to add in
key-conflicts without resolving them is not a state to leave blender
in.
On Sat, Dec 11, 2010 at 3:25 AM, Doug Ollivier <doug at flipdesign.co.nz> wrote:
> I'd like to put my two cents in that consistency is the No1 priority
> within any interface. Inconsistency causes thinking > thinking slows
> down actions.
>
> One aspect of Blender's naming scheme, is the ability to work out that
> the key should be 'h' by the tools name such as 'Handle' (which I assume
> is the logic in using the H key)
> However this has already been used for Hide, so IMO is off limits if the
> hide command is ever to be used to hide handles.
>
> Other software often use a modifier key such as Ctrl or Alt to click on
> a handle and drag it to convert it. Can we use one of these modifier
> keys in conjunction with a mouse action on the handle? or would this
> conflict with another Blender action?
>
> I.e. Pressing a modifier key then dragging a straight handle will
> convert it to the [ V ] type handle from a [ | ] type handle.
> Secondly pressing a modifier key and clicking on a handle will snap it
> back to the control point to remove the handle [ . ] .
> Thirdly pressing a modifier key and clicking/dragging on a control-point
> will drag an aligned handle out of it so that we are back where we
> started [ | ]
>
> This way people can do it without even needing to think of a key since
> they just hold and drag or click to get whatever they want.
>
> Cheers,
>
> Doug Ollivier BDes (Hons)
> Industrial Interface Designer
>
> On 10/12/2010 11:14 p.m., Ton Roosendaal wrote:
>> Hi,
>>
>> Sorry; my action was too quick... I have some stuff to catch up with :)
>>
>> Curve editing hotkeys are among the most used for editing, so they
>> deserve quick one-handed access.
>>
>> I'm mostly concerned that the usablity of Blender downgraded just for
>> the sake of an enforced consistancy. The clunkiness of the handle menu
>> should have not been accepted in the first place.
>>
>> There's probably enough free other keys though... but if we strive for
>> total consistancy in Blender everywhere, you will very quickly run out
>> of hotkeys. In certain cases we'll just have to live with exceptions
>> then.
>>
>> -Ton-
>>
>> ------------------------------------------------------------------------
>> Ton Roosendaal Blender Foundation ton at blender.org www.blender.org
>> Blender Institute Entrepotdok 57A 1018AD Amsterdam The Netherlands
>>
>> On 10 Dec, 2010, at 1:21, Jason van Gumster wrote:
>>
>>> Whatever the ultimate decision is, I'd like to submit a small
>>> request that the
>>> hotkeys for manipulating f-curves be consistent with what's chosen
>>> for changing
>>> handle types on curve objects. So if it's Ctrl+1,2,3,4,5 in the 3D
>>> View, please
>>> make it the same keys in the Graph Editor and Dopesheet.
>>>
>>> -Jason
>>>
>>> Martin Poirier<theeth at yahoo.com> wrote:
>>>
>>>> I'll agree with that too. Better to reassign handle hotkeys and have
>>>> consistent hotkeys for hide/unhide/show only selected.
>>>>
>>>> Martin
>>>>
>>>> --- On Thu, 12/9/10, Joshua Leung<aligorith at gmail.com> wrote:
>>>>
>>>>> From: Joshua Leung<aligorith at gmail.com>
>>>>> Subject: Re: [Bf-committers] [Bf-blender-cvs] SVN
>>>>> commit: /data/svn/bf-blender [33578] trunk/blender/source/blender/
>>>>> editors/curve: Related to previous commit: To: "bf-blender
>>>>> developers"
>>>>> <bf-committers at blender.org> Received: Thursday, December 9, 2010,
>>>>> 6:56 PM I
>>>>> have to agree with this with regard to the keyframe handle-type
>>>>> changes too. Although it's true that the single menu
>>>>> approach can feel
>>>>> a bit clunky in relation to just direct hotkey<->
>>>>> handle-type
>>>>> mapping, it's not much use when the single keys end up
>>>>> being scattered
>>>>> around so much that it's really hard to remember them.
>>>>>
>>>>> If we ultimately do need direct-hotkey access, perhaps we
>>>>> could
>>>>> consider another scheme instead, where all the options are
>>>>> side-by-side instead of having them scattered using
>>>>> different modifier
>>>>> combinations, so that there is a logical grouping on the
>>>>> keyboard.
>>>>>
>>>>> For example, we could consider assigning: Ctrl 1,2,3,4,(5)
>>>>> to the
>>>>> handle types in Curve EditMode and also in Animation
>>>>> Editors. At least
>>>>> when I checked a moment ago, these weren't assigned yet :)
>>>>>
>>>>> On Fri, Dec 10, 2010 at 12:41 PM, Campbell Barton<ideasman42 at gmail.com
>>>>> wrote:
>>>>>> I was never able to memorize the curve keys properly,
>>>>> even when
>>>>>> editing curves frequently.
>>>>>> They are not very logical and seem quite randomly
>>>>> selected.
>>>>>> While they are frequently used, this is just a case
>>>>> where you use the
>>>>>> number keys to select a menu item IMHO.
>>>>>>
>>>>>> On Thu, Dec 9, 2010 at 7:06 PM, Ton Roosendaal<ton at blender.org>
>>>>> wrote:
>>>>>>> Revision: 33578
>>>>>>> http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=33578
>>>>>>> Author: ton
>>>>>>> Date: 2010-12-09 20:06:45 +0100 (Thu, 09 Dec
>>>>> 2010)
>>>>>>> Log Message:
>>>>>>> -----------
>>>>>>> Related to previous commit:
>>>>>>>
>>>>>>> I still have to learn more of the recent changes
>>>>> in code :)
>>>>>>> Didn't know the handle type options became a menu
>>>>> for Curve edit mode.
>>>>>>> Providing much-used tools non-modal (direct)
>>>>> really should have
>>>>>>> preference. Pull down is not very accessible here
>>>>> though, will
>>>>>>> check on it later. :)
>>>>>>>
>>>>>>> This restores H, Shift+H, V and alt+H for handle
>>>>> setting.
>>>>>>> Modified Paths:
>>>>>>> --------------
>>>>>>>
>>>>> trunk/blender/source/blender/editors/curve/curve_ops.c
>>>>> trunk/blender/source/blender/editors/curve/editcurve.c
>>>>>>> Modified:
>>>>> trunk/blender/source/blender/editors/curve/curve_ops.c
>>>>> ===================================================================
>>>>>>> ---
>>>>> trunk/blender/source/blender/editors/curve/curve_ops.c
>>>>> 2010-12-09 18:31:40 UTC (rev 33577)
>>>>>>> +++
>>>>> trunk/blender/source/blender/editors/curve/curve_ops.c
>>>>> 2010-12-09 19:06:45 UTC (rev 33578)
>>>>>>> @@ -195,7 +195,12 @@
>>>>>>> keymap->poll=
>>>>> ED_operator_editsurfcurve;
>>>>>>> WM_keymap_add_menu(keymap,
>>>>> "INFO_MT_edit_curve_add", AKEY, KM_PRESS, KM_SHIFT, 0);
>>>>>>> - WM_keymap_add_menu(keymap,
>>>>> "INFO_MT_curve_handle_type_set", VKEY, KM_PRESS, 0, 0);
>>>>>>> +
>>>>>
>>>>>
>>>>> /* XXX will fix it with
>>>>> proper defines (ton) */
>>>>>>> + RNA_enum_set(WM_keymap_add_item(keymap,
>>>>> "CURVE_OT_handle_type_set", HKEY, KM_PRESS, 0, 0)->ptr,
>>>>> "type", 5);
>>>>>>> + RNA_enum_set(WM_keymap_add_item(keymap,
>>>>> "CURVE_OT_handle_type_set", HKEY, KM_PRESS, KM_SHIFT,
>>>>> 0)->ptr, "type", HD_AUTO);
>>>>>>> + RNA_enum_set(WM_keymap_add_item(keymap,
>>>>> "CURVE_OT_handle_type_set", HKEY, KM_PRESS, KM_ALT,
>>>>> 0)->ptr, "type", 6);
>>>>>>> + RNA_enum_set(WM_keymap_add_item(keymap,
>>>>> "CURVE_OT_handle_type_set", VKEY, KM_PRESS, 0, 0)->ptr,
>>>>> "type", HD_VECT);
>>>>>>> +
>>>>>>> WM_keymap_add_item(keymap,
>>>>> "CURVE_OT_vertex_add", LEFTMOUSE, KM_CLICK, KM_CTRL, 0);
>>>>>>> WM_keymap_add_item(keymap,
>>>>> "CURVE_OT_select_all", AKEY, KM_PRESS, 0, 0);
>>>>>>> Modified:
>>>>> trunk/blender/source/blender/editors/curve/editcurve.c
>>>>> ===================================================================
>>>>>>> ---
>>>>> trunk/blender/source/blender/editors/curve/editcurve.c
>>>>> 2010-12-09 18:31:40 UTC (rev 33577)
>>>>>>> +++
>>>>> trunk/blender/source/blender/editors/curve/editcurve.c
>>>>> 2010-12-09 19:06:45 UTC (rev 33578)
>>>>>>> @@ -3537,11 +3537,11 @@
>>>>>>> void CURVE_OT_handle_type_set(wmOperatorType
>>>>> *ot)
>>>>>>> {
>>>>>>> static EnumPropertyItem type_items[]=
>>>>> {
>>>>>>> - {1, "AUTOMATIC", 0,
>>>>> "Automatic", ""},
>>>>>>> - {2, "VECTOR", 0, "Vector",
>>>>> ""},
>>>>>>> - {3, "TOGGLE_FREE_ALIGN", 0,
>>>>> "Toggle Free/Align", ""},
>>>>>>> + {HD_AUTO, "AUTOMATIC", 0,
>>>>> "Automatic", ""},
>>>>>>> + {HD_VECT, "VECTOR", 0,
>>>>> "Vector", ""},
>>>>>>> {5, "ALIGN", 0, "Align",
>>>>> ""},
>>>>>>> {6, "FREE_ALIGN", 0, "Free
>>>>> Align", ""},
>>>>>>> + {3, "TOGGLE_FREE_ALIGN", 0,
>>>>> "Toggle Free/Align", ""},
>>>>>>> {0, NULL, 0, NULL, NULL}};
>>>>>>>
>>>>>>> /* identifiers */
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers at blender.org
>>> http://lists.blender.org/mailman/listinfo/bf-committers
>>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
--
- Campbell
More information about the Bf-committers
mailing list