[Bf-committers] SVN commit: /data/svn/bf-blender [28086] trunk/blender/source/blender/imbuf /intern/anim.c: Fix for previous FFMPEG commit, needs extra version ifdefs

Xavier Thomas xavier.thomas.1980 at gmail.com
Thu Apr 8 16:45:42 CEST 2010


Hello,

Sorry for not participating before with this subject, but I see 2
problems with this commit:

- Firt we do not need to set the transform each time we fetch an ibuf,
I am pretty sure that putting this in startffmpeg (around line 638 )
would be much better
- Second here with:
#define LIBAVCODEC_VERSION_MAJOR 52
#define LIBAVCODEC_VERSION_MINOR 59
#define LIBAVCODEC_VERSION_MICRO  0
and #define
LIBSWSCALE_VERSION_MAJOR 0
#define LIBSWSCALE_VERSION_MINOR 10
#define LIBSWSCALE_VERSION_MICRO 0

I never pass the
#if (LIBAVCODEC_VERSION_MAJOR >= 52) && (LIBAVCODEC_VERSION_MINOR >= 29) && \
	 (LIBSWSCALE_VERSION_MAJOR >= 10) && (LIBSWSCALE_VERSION_MINOR >= 0)

I suppose you inverted LIBSWSCALE_VERSION_MAJOR / MINOR


Xavier


More information about the Bf-committers mailing list