[Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20478] trunk/blender/source/blender: Bullet Physics maxphystep = 1 is better general default to avoid vicious circle

[Benoit Bolsee]

I don't think this commit is wise: it most cases, the physics is not the
limiting factor (the vault demo is not typical with this regards) and
allowing up to 5 physics steps per game frame maintains physics accuracy
when the graphics slows down the game without degrading the performance
much more (the typical case).
Besides that it's too close to release to make that change. For backward
compatibility, we need to maintain the original behavior, which was 5
physics frame.

I will change it back.

Benoit

> Date: Fri, 29 May 2009 00:26:29 +0200 (CEST)
> From: Erwin Coumans <blender at erwincoumans.com>
> Subject: [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [20478]
> 	trunk/blender/source/blender: Bullet Physics maxphystep 
> = 1 is better
> 	general default to avoid vicious circle
> To: bf-blender-cvs at blender.org
> Message-ID: <20090528222629.429C2399BB at proog.blender.org>
> Content-Type: text/plain; charset=UTF-8
> 
> Revision: 20478
>           
> http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=re
> v&root=bf-blender&revision=20478
> Author:   erwin
> Date:     2009-05-29 00:26:28 +0200 (Fri, 29 May 2009)
> 
> Log Message:
> -----------
> Bullet Physics maxphystep = 1 is better general default to 
> avoid vicious circle (graphics slower -> physics slower -> 
> overall frametime slower -> graphics slower etc.) See 
> difference in vault.blend
> 
> Modified Paths:
> --------------
>     trunk/blender/source/blender/blenkernel/intern/world.c
>     trunk/blender/source/blender/blenloader/intern/readfile.c
> 
> Modified: trunk/blender/source/blender/blenkernel/intern/world.c
> ===================================================================
> --- trunk/blender/source/blender/blenkernel/intern/world.c	
> 2009-05-28 20:28:52 UTC (rev 20477)
> +++ trunk/blender/source/blender/blenkernel/intern/world.c	
> 2009-05-28 22:26:28 UTC (rev 20478)
> @@ -112,7 +112,7 @@
>  	wrld->ticrate = 60;
>  	wrld->maxlogicstep = 5;
>  	wrld->physubstep = 1;
> -	wrld->maxphystep = 5;
> +	wrld->maxphystep = 1;
>  
>  	return wrld;
>  }
> 
> Modified: trunk/blender/source/blender/blenloader/intern/readfile.c
> ===================================================================
> --- trunk/blender/source/blender/blenloader/intern/readfile.c	
> 2009-05-28 20:28:52 UTC (rev 20477)
> +++ trunk/blender/source/blender/blenloader/intern/readfile.c	
> 2009-05-28 22:26:28 UTC (rev 20478)
> @@ -8131,7 +8131,7 @@
>  			wrld->ticrate = 60;
>  			wrld->maxlogicstep = 5;
>  			wrld->physubstep = 1;
> -			wrld->maxphystep = 5;
> +			wrld->maxphystep = 1;
>  		}
>  	}
>  
>